Added xvalidate CEP rule for GatewayAddresses#4838
Conversation
Signed-off-by: Sowmyaa Dixit <sowmyaadixit@gmail.com>
Signed-off-by: Sowmyaa Dixit <sowmyaadixit@gmail.com>
Signed-off-by: Sowmyaa Dixit <sowmyaadixit@gmail.com>
Signed-off-by: Sowmyaa Dixit <sowmyaadixit@gmail.com>
Signed-off-by: Sowmyaa Dixit <sowmyaadixit@gmail.com>
Signed-off-by: Sowmyaa Dixit <sowmyaadixit@gmail.com>
Signed-off-by: Sowmyaa Dixit <sowmyaadixit@gmail.com>
SowmyaaDixit
requested review from
MortalHappiness,
andrewsykim,
kevin85421 and
rueian
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12b24df956
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| maxItems: 16 | ||
| type: array | ||
| gatewayClassName: |
There was a problem hiding this comment.
The Helm-packaged RayService CRD adds gatewayAddresses but omits the list-level CEL validations (and x-kubernetes-list-type: atomic) that were added in ray-operator/config/crd/bases/ray.io_rayservices.yaml. As a result, clusters installed via Helm will accept duplicate IPAddress/Hostname entries that should be rejected, so the new uniqueness enforcement is bypassed for a common deployment path and behavior diverges by installation method.
Useful? React with 👍 / 👎.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 12b24df. Configure here.
Signed-off-by: SowmyaaDixit <85265649+SowmyaaDixit@users.noreply.github.com>
1 participant
Why are these changes needed?
As a follow up to my previous PR
Adding an xvalidate CEP rule for GatewayAddresses.
Note: This PR will be merged after above PR. So that after rebase with main branch it will only show the xvalidate part with unit test.
Related issue number
Checks