Fix Fantom REPL crash from metro default import#57443
Closed
rubennorte wants to merge 1 commit into
Closed
Conversation
Summary: The Fantom REPL (`yarn fantom-cli`) crashed on startup with `TypeError: Cannot read properties of undefined (reading 'loadConfig')`. `metro` is a CommonJS module that only provides named exports, so the default import `import Metro from 'metro'` resolves to `undefined` under the Babel interop used to run the REPL, and any access such as `Metro.loadConfig` throws. Switch to a namespace import (`import * as Metro from 'metro'`), matching how metro is already imported in the Fantom global setup. Changelog: [Internal] Differential Revision: D110754395
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110754395. |
|
This pull request has been merged in af3a651. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The Fantom REPL (
yarn fantom-cli) crashed on startup withTypeError: Cannot read properties of undefined (reading 'loadConfig').metrois a CommonJS module that only provides named exports, so the default importimport Metro from 'metro'resolves toundefinedunder the Babel interop used to run the REPL, and any access such asMetro.loadConfigthrows.Switch to a namespace import (
import * as Metro from 'metro'), matching how metro is already imported in the Fantom global setup.Changelog: [Internal]
Differential Revision: D110754395