Skip to content

Mirror MCPExternalAuthConfig Valid=False onto consumer CR conditions #5354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgrunnagle merged 5 commits into from
May 22, 2026

Consolidate mirror helpers; tighten error+test contract

c9d0a70
Select commit
Loading
Failed to load commit list.
Merged

Mirror MCPExternalAuthConfig Valid=False onto consumer CR conditions #5354

Consolidate mirror helpers; tighten error+test contract
c9d0a70
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 21, 2026 in 1s

68.65% (-0.03%) compared to 483e91d

View this Pull Request on Codecov

68.65% (-0.03%) compared to 483e91d

Details

Codecov Report

❌ Patch coverage is 89.41176% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.65%. Comparing base (483e91d) to head (c9d0a70).

Files with missing lines Patch % Lines
...perator/controllers/virtualmcpserver_controller.go 77.77% 7 Missing and 1 partial ⚠️
...d/thv-operator/controllers/mcpserver_controller.go 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5354      +/-   ##
==========================================
- Coverage   68.68%   68.65%   -0.03%     
==========================================
  Files         625      626       +1     
  Lines       63298    63365      +67     
==========================================
+ Hits        43474    43505      +31     
- Misses      16583    16619      +36     
  Partials     3241     3241

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov