Skip to content

perf(pm): remove obsolete resolver preload#3044

Draft
elrrrrrrr wants to merge 1 commit into
perf/pm-split-resolver-mainloop-testsfrom
perf/pm-split-resolver-remove-preload
Draft

perf(pm): remove obsolete resolver preload#3044
elrrrrrrr wants to merge 1 commit into
perf/pm-split-resolver-mainloop-testsfrom
perf/pm-split-resolver-remove-preload

Conversation

@elrrrrrrr
Copy link
Copy Markdown
Contributor

Summary

  • remove the old resolver preload module after demand BFS takes over manifest scheduling
  • drop preload-only progress events
  • keep demand BFS progress events intact

Validation

  • cargo fmt
  • cargo check -p utoo-ruborist
  • cargo test -p utoo-ruborist --lib
  • cargo clippy --all-targets -- -D warnings --no-deps

Split Plan

Part of the resolver stack split from source PR #3028. This is a cleanup PR after #3043 switches scheduling to the demand mainloop.

@elrrrrrrr elrrrrrrr added A-Pkg Manager Area: Package Manager benchmark Run pm-bench on PR labels May 21, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the manifest preloading functionality from the resolver, including the deletion of the preload module and the removal of preload-related variants from the BuildEvent enum. I have no feedback to provide.

@elrrrrrrr elrrrrrrr force-pushed the perf/pm-split-resolver-demand-mainloop branch from 54b55da to 2948997 Compare May 21, 2026 19:21
@elrrrrrrr elrrrrrrr changed the base branch from perf/pm-split-resolver-demand-mainloop to perf/pm-split-resolver-mainloop-tests May 21, 2026 19:25
@elrrrrrrr elrrrrrrr force-pushed the perf/pm-split-resolver-remove-preload branch from fedab9c to 3a49840 Compare May 21, 2026 19:26
@elrrrrrrr elrrrrrrr force-pushed the perf/pm-split-resolver-mainloop-tests branch from 698c5e7 to 5acdc80 Compare May 21, 2026 22:32
@elrrrrrrr elrrrrrrr force-pushed the perf/pm-split-resolver-remove-preload branch 2 times, most recently from 0b4c7d5 to c12fd4c Compare May 21, 2026 23:09
@elrrrrrrr elrrrrrrr force-pushed the perf/pm-split-resolver-remove-preload branch from c12fd4c to fc7be5f Compare May 21, 2026 23:39
@elrrrrrrr elrrrrrrr force-pushed the perf/pm-split-resolver-mainloop-tests branch from 286856e to f8cd7ab Compare May 21, 2026 23:39
@github-actions
Copy link
Copy Markdown

📊 pm-bench-phases · f958e8b · linux (ubuntu-latest)

Workflow run — ant-design

PMs: utoo (this branch) · utoo-npm (latest published) · bun (latest)

npmjs.org

p0_full_cold

PM wall ±σ user sys RSS pgMinor
utoo-next 8.47s 0.31s 10.88s 12.82s 1003M 126.4K
utoo-npm 8.28s 0.01s 11.29s 13.10s 984M 116.6K
utoo 8.70s 1.02s 11.80s 12.85s 948M 135.9K
bun 0.00s 0.00s 10.99s 10.81s 716M 343.4K
PM vCtx iCtx netRX netTX cache node_mod lock
utoo-next 113.3K 80.0K 1.16G 5M 1.71G 1.70G 2M
utoo-npm 130.1K 96.3K 1.16G 5M 1.71G 1.70G 2M
utoo 111.0K 62.9K 1.16G 6M 1.71G 1.70G 2M
bun 14.7K 17.4K 1.19G 6M 1.86G 1.75G -

p1_resolve

PM wall ±σ user sys RSS pgMinor
bun 2.11s 0.12s 4.15s 1.10s 493M 169.2K
utoo-next 2.96s 0.06s 5.52s 1.79s 606M 88.1K
utoo-npm 3.17s 0.07s 5.72s 2.09s 617M 83.8K
utoo 2.57s 0.19s 6.21s 1.64s 641M 117.5K
PM vCtx iCtx netRX netTX cache node_mod lock
bun 8.4K 4.6K 203M 3M 107M - 1M
utoo-next 47.2K 73.1K 200M 2M 7M 3M 2M
utoo-npm 71.0K 89.3K 200M 2M 7M 3M 2M
utoo 14.3K 19.4K 201M 3M 7M 3M 2M

p3_cold_install

PM wall ±σ user sys RSS pgMinor
bun 7.29s 0.49s 6.41s 10.71s 629M 223.0K
utoo-next 7.17s 1.40s 5.35s 11.85s 507M 60.1K
utoo-npm 6.62s 0.52s 5.31s 11.42s 472M 63.2K
utoo 6.15s 0.35s 5.38s 11.51s 472M 59.3K
PM vCtx iCtx netRX netTX cache node_mod lock
bun 4.3K 6.9K 1017M 3M 1.76G 1.76G 1M
utoo-next 106.0K 53.8K 989M 3M 1.70G 1.70G 2M
utoo-npm 97.9K 51.2K 989M 2M 1.70G 1.70G 2M
utoo 90.2K 52.8K 989M 2M 1.70G 1.70G 2M

p4_warm_link

PM wall ±σ user sys RSS pgMinor
bun 3.67s 0.06s 0.20s 2.51s 134M 31.6K
utoo-next 2.29s 0.05s 0.55s 3.96s 79M 18.7K
utoo-npm 2.34s 0.07s 0.57s 3.93s 78M 18.2K
utoo 2.20s 0.01s 0.54s 4.01s 79M 18.2K
PM vCtx iCtx netRX netTX cache node_mod lock
bun 253 22 22K 17K 1.87G 1.76G 1M
utoo-next 41.7K 19.7K 5K 7K 1.70G 1.70G 2M
utoo-npm 41.2K 20.8K 7K 21K 1.70G 1.70G 2M
utoo 42.6K 20.8K 5K 6K 1.71G 1.70G 2M

npmmirror.com: no output captured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Pkg Manager Area: Package Manager benchmark Run pm-bench on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant