SGX build does not have fcntl.h#10524
Open
JacobBarthelmeh wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the close-on-exec helper declarations/definitions so they are not built for WOLFSSL_SGX, avoiding inclusion of <fcntl.h> in SGX builds (where it isn’t available) and fixing the nightly SGX build failure.
Changes:
- Exclude
WOLFSSL_SGXfrom the Unix/Applewc_*_cloexechelper prototypes inwc_port.h. - Exclude
WOLFSSL_SGXfrom the Unix/Applewc_*_cloexechelper implementations (and<fcntl.h>include) inwc_port.c. - Update the closing
#endifcomment inwc_port.cto reflect the new condition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| wolfssl/wolfcrypt/wc_port.h | Avoids exposing the Unix/Apple close-on-exec helper prototypes when building for SGX. |
| wolfcrypt/src/wc_port.c | Prevents compiling the close-on-exec helpers (and including <fcntl.h>) under SGX to fix SGX build environments lacking that header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Retest this please Jenkins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for nightly SGX test