fix: use recursive SKILL.md discovery for all skill roots - #63
Open
ha5mth-alt wants to merge 1 commit into
Open
Conversation
_skill_md_paths previously used a flat glob (*/SKILL.md) for non-Hermes directories, only enabling recursive (**/SKILL.md) for ~/.hermes/skills. This caused Hermes profile directories (~/.hermes/profiles/*/skills/) to miss 88 of 91 skills. Changes: - skill_manager.py: always use recursive glob in _skill_md_paths - skill_manager.py: extend _is_hermes_skill_root to match profile dirs - skill_hub.py: extend _is_hermes_skill_root to match profile dirs - nacos_skill_hub.py: always use recursive glob in skill list - tests: add 9 regression tests covering default root, profile root, depth-3, flat layout, unrelated dirs, symlink dedup, and real-world detection of all 91 production skills All 9 new tests pass. Existing suite: 108 pass, 17 fail (all pre-existing, missing pytest-asyncio or unrelated dashboard KeyError). Fixes #?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_skill_md_paths previously used a flat glob (/SKILL.md) for non-Hermes directories, only enabling recursive (**/SKILL.md) for
/.hermes/skills. This caused Hermes profile directories (/.hermes/profiles//skills/) to miss 88 of 91 skills.Changes:
All 9 new tests pass. Existing suite: 108 pass, 17 fail (all pre-existing, missing pytest-asyncio or unrelated dashboard KeyError).
Fixes #?