fix: call load_attributes before load_commands#31
Open
ramundomario wants to merge 2 commits into
Open
Conversation
Otherwise the settings command will retain the default value instead of the real ones in attributes. Fixes Andre0512/hon#238
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
pyhonproject, focusing on correcting the order of asynchronous method calls and updating the package version.Improvements to method execution order:
python/hon.py: Moved theawait appliance.load_commands()call to ensure it executes beforeawait appliance.load_attributes()for proper command loading.ℹ️ Otherwise the settings command will retain the default value instead of the real ones in attributes:
The
sync_params_to_commandcalled inload_commandswill not find the real data in attributes (ref) if not loaded beforePackage version update:
setup.py: Updated the version from0.17.5to0.17.6to reflect the latest changes.Fixes Andre0512/hon#238