Skip to content

feat(library <-> taxonomy check)#214

Open
dusanparipovic wants to merge 11 commits into
developfrom
models-taxonomy-check
Open

feat(library <-> taxonomy check)#214
dusanparipovic wants to merge 11 commits into
developfrom
models-taxonomy-check

Conversation

@dusanparipovic
Copy link
Copy Markdown
Contributor

No description provided.

… implement corresponding unit test for YAML parsing
…my category

- Introduced optional `properties` for components in `system.yml`, allowing key/value pairs that are normalized into a dictionary.
- Added optional `taxonomy-category` field for models in library YAML files, accessible via `ModelSchema.taxonomy_category`.
- Updated documentation to reflect these changes and provided examples in the user guide.
- Updated documentation to replace "key" with "id" in the context of component properties in `system.yml`.
- Adjusted test assertions to reflect the change from "key" to "id" for consistency with the updated documentation.
- Ensured that error messages for duplicate properties also refer to "id" instead of "key".
- Added a new `Study` dataclass that combines `System` and `DataBase`, centralizing consistency checks.
- Updated `build_problem()` and `build_decomposed_problems()` to accept `Study` directly.
- Refactored related functions and tests to utilize the new `Study` structure, ensuring seamless integration.
- Removed redundant parameters and streamlined the API for better clarity and usability.
@dusanparipovic
Copy link
Copy Markdown
Contributor Author

Open questions:

  • This PR opens again question about shared library which will be used across our gems eco system.
  • In fact we have duplicate of class for Taxonomy inside GVB and Gemspy.
  • Also this PR opens question: do we want to be able to have multiple taxonomies and do we want to reference it inside library file.
  • For more details see issue inside GVB

@dusanparipovic
Copy link
Copy Markdown
Contributor Author

Open questions:

  • This PR opens again question about shared library which will be used across our gems eco system.
  • In fact we have duplicate of class for Taxonomy inside GVB and Gemspy.
  • Also this PR opens question: do we want to be able to have multiple taxonomies and do we want to reference it inside library file.
  • For more details see issue inside GVB

@aoustry @tbittar

@dusanparipovic dusanparipovic requested review from aoustry and tbittar and removed request for tbittar May 29, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant