feat: append Minecraft version to build artifact name#545
Open
MR-kartoshki wants to merge 1 commit into
Open
Conversation
build.gradle version set to \${mod_version}-\${minecraft_version}, producing outputs like meteor-rejects-addon-0.3-1.21.11.jar. fabric.mod.json stamped with the same version string.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
ok??? read the fucking post? this has nothing to do with 0.3 this has to do with the minecraft version |
Author
well why would you be "just saying lmao" under an unrelated PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.gradle version set to ${mod_version}-${minecraft_version}, producing outputs like meteor-rejects-addon-0.3-1.21.11.jar. fabric.mod.json stamped with the same version string.
Description
Updates build.gradle to set version as ${mod_version}-${minecraft_version}, producing artifacts like meteor-rejects-addon-0.3-1.21.11.jar.
Related Issue
#544
Motivation and Context
Without the Minecraft version in the artifact name, it's unclear which MC version a given jar targets. This makes it easier to identify builds. I currently have 4 different meteor-rejects-addon-0.3.jar for different versions and it's hard to differentiate.
How Has This Been Tested?
Built locally with ./gradlew build. Output jar confirmed as meteor-rejects-addon-0.3-1.21.11.jar.
Screenshots (if appropriate):
Types of changes