Skip to content

improve: add missing type widening entries for bool/date combinations#41

Open
Coding-Dev-Tools wants to merge 1 commit into
masterfrom
improve/datamorph-20260630
Open

improve: add missing type widening entries for bool/date combinations#41
Coding-Dev-Tools wants to merge 1 commit into
masterfrom
improve/datamorph-20260630

Conversation

@Coding-Dev-Tools

Copy link
Copy Markdown
Owner

Automated improvement by dev-engineer.

Adds 7 missing type widening rules to the _type_widening dict in converters.py:

  • bool <-> int64, bool <-> float64, bool <-> date, date <-> string
  • Prevents silent fallback to "string" when bool or date values appear alongside numeric types during schema inference.

Adds corresponding test coverage for the new widening paths.

All 132 tests pass, lint clean.

Adds 7 missing type widening rules to _type_widening dict:
- bool <-> int64, bool <-> float64, bool <-> date, date <-> string
- Prevents silent fallback to 'string' when bool or date values
  appear alongside numeric types during schema inference.

Adds corresponding test coverage for the new widening paths.
@github-actions

Copy link
Copy Markdown

🤖 Automated Code Review

✅ Ruff Lint — No issues

⚠️ Ruff Format — Formatting needed

Would reformat: conftest.py
Would reformat: src/datamorph/cli.py
Would reformat: src/datamorph/converters.py
Would reformat: tests/test_cli_error_paths.py
Would reformat: tests/test_converters.py
Would reformat: tests/test_edge_cases.py
Would reformat: tests/test_validate.py
7 files would be reformatted, 2 files already formatted

✅ Secret Detection — Clean

✅ Large Files — Within limits

📊 Diff Stats — 2 file(s) changed

 src/datamorph/converters.py |  7 +++++++
 tests/test_converters.py    | 13 +++++++++++++
 2 files changed, 20 insertions(+)

Verdict: ⚠️ Warnings — Lint/format issues found. Recommend fixing before merge.

Automated by Coding-Dev-Tools/.github reusable workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant