improve: add missing type widening entries for bool/date combinations#41
Open
Coding-Dev-Tools wants to merge 1 commit into
Open
improve: add missing type widening entries for bool/date combinations#41Coding-Dev-Tools wants to merge 1 commit into
Coding-Dev-Tools wants to merge 1 commit into
Conversation
Adds 7 missing type widening rules to _type_widening dict: - bool <-> int64, bool <-> float64, bool <-> date, date <-> string - Prevents silent fallback to 'string' when bool or date values appear alongside numeric types during schema inference. Adds corresponding test coverage for the new widening paths.
🤖 Automated Code Review✅ Ruff Lint — No issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated improvement by dev-engineer.
Adds 7 missing type widening rules to the
_type_wideningdict inconverters.py:bool <-> int64,bool <-> float64,bool <-> date,date <-> string"string"when bool or date values appear alongside numeric types during schema inference.Adds corresponding test coverage for the new widening paths.
All 132 tests pass, lint clean.