Skip to content

Add ERC721 NFT dev faucet - #15

Open
SamuelMoor-Smith wants to merge 5 commits into
Divide-By-0:mainfrom
SamuelMoor-Smith:nft-faucet
Open

Add ERC721 NFT dev faucet#15
SamuelMoor-Smith wants to merge 5 commits into
Divide-By-0:mainfrom
SamuelMoor-Smith:nft-faucet

Conversation

@SamuelMoor-Smith

Copy link
Copy Markdown
Contributor

Hope this is similar to what you are looking for. Let me know if there is anything else you want me to add or change :)

Hope this is similar to what you are looking for. Let me know if there is anything else you want me to add or change :)
@Divide-By-0

Copy link
Copy Markdown
Owner

Awesome! I hope this gets some usage. I bought https://nftfaucet.dev, if you send aayushg@mit.edu your email address, I can add you as an owner and you can redirect that here!

Two notes.

  1. Can you add some default image, unique to each NFT? This would have been helpful when I was debugging https://vickrey.xyz for instance. For instance, you can use the Uniswap NFTSVG library, or use any other simple on-chain programmatic image generation method (i.e. a gravitar or like 16 boxes with random colors seeded by the number or whatever).
  2. Why is the 1e14 wei fee needed? Can we do something more creative with the extra Goerli eth, maybe use it to auto-replenish some Goerli faucet?

@SamuelMoor-Smith

SamuelMoor-Smith commented May 6, 2023

Copy link
Copy Markdown
Contributor Author

Awesome! I hope this gets some usage. I bought https://nftfaucet.dev, if you send aayushg@mit.edu your email address, I can add you as an owner and you can redirect that here!

Two notes.

  1. Can you add some default image, unique to each NFT? This would have been helpful when I was debugging https://vickrey.xyz for instance. For instance, you can use the Uniswap NFTSVG library, or use any other simple on-chain programmatic image generation method (i.e. a gravitar or like 16 boxes with random colors seeded by the number or whatever).
  2. Why is the 1e14 wei fee needed? Can we do something more creative with the extra Goerli eth, maybe use it to auto-replenish some Goerli faucet?

So sorry, I got caught up in exams and forgot to finish this. I just graduated and have settled down so I will make the changes before tomorrow! I am currently looking at a few more of the ideas to work on before I start my Masters in the Fall. This is such a great program you have going and it is such a good way to learn about different areas of open-source development.

@Divide-By-0

Copy link
Copy Markdown
Owner

Hey let me know when you've updated the PR with the unique images -- I think there are some merge conflicts now!

@SamuelMoor-Smith

Copy link
Copy Markdown
Contributor Author

Hey let me know when you've updated the PR with the unique images -- I think there are some merge conflicts now!

This has been updated. All changes are on the site: https://nft-faucet-three.vercel.app/

@SamuelMoor-Smith

Copy link
Copy Markdown
Contributor Author

@Divide-By-0 sorry, just wondering if there we're changes you wanted me to make to this?

@Divide-By-0

Divide-By-0 commented Aug 7, 2023

Copy link
Copy Markdown
Owner

Hey, the NFTs don't show up on opensea and don't have random metadata. Do you mind adding those? @SamuelMoor-Smith sorry about the late response.

In retrospect you can buy NFTs pretty cheap off of OpenSea so not sure how relevant this bounty still is, but I'll still award it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants