Skip to content

Persistent filter state between reports and runs pages #4868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gulyasgergely902 merged 2 commits into from
Jun 3, 2026
Merged

Persistent filter state between reports and runs pages #4868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56e9de0
feat(presets): persist filter state between reports and runs pages
feyruzb May 29, 2026
9cf770b
refactor: get rid of unnecessary router querying
feyruzb Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions web/server/vue-cli/src/components/Report/ReportFilter/Filters/PresetMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
</template>

<script setup>
import { computed, onMounted, ref, watch } from "vue";
import { computed, nextTick, onMounted, ref, watch } from "vue";
import isEqual from "lodash/isEqual";
import {
authService,
Expand Down Expand Up @@ -86,7 +86,7 @@ const activePresetName = computed(() => {
return preset?.name || "";
});

watch(() => route.query, newQuery => {
function checkModified(currentQuery) {
if (!activePresetId.value || !querySnapshot.value) {
isModified.value = false;
return;
Expand All @@ -113,14 +113,20 @@ watch(() => route.query, newQuery => {
}
return sorted;
};
const normNew = normalize(newQuery);
const normNew = normalize(currentQuery);
const normSnap = normalize(querySnapshot.value);

isModified.value = !isEqual(normNew, normSnap);
}

watch(() => route.query, newQuery => {
checkModified(newQuery);
}, { deep: true });

watch(activePresetId, () => {
watch(activePresetId, newVal => {
if (newVal == null || settingPreset.value) return;
settingPreset.value = true;
emit("apply-preset", activePresetId.value);
emit("apply-preset", newVal);
settingPreset.value = false;
});

Expand Down Expand Up @@ -174,6 +180,7 @@ async function fetchPresets() {

function onPresetApplied(savedQuery) {
querySnapshot.value = savedQuery ? { ...savedQuery } : { ...route.query };
checkModified(route.query);
}

function clearPresetState() {
Expand Down Expand Up @@ -219,13 +226,22 @@ async function selectPresetAfterSave(id) {
isModified.value = false;
}

async function selectPresetSilently(id) {
settingPreset.value = true;
activePresetId.value = id;
await nextTick();
settingPreset.value = false;
}

defineExpose({
activePresetId,
activePresetName,
isModified,
onPresetApplied,
clearPresetState,
selectPresetAfterSave,
selectPresetSilently,
fetchPresets,
});

</script>
Expand Down
Loading
Loading