feat: choose project administrators on project creation by kyle-ssg · Pull Request #7580 · Flagsmith/flagsmith

kyle-ssg · 2026-05-22T13:56:01Z

Thanks for submitting a PR! Please check the boxes below:

I have read the Contributing Guide.
I have added information to `docs/` if required so people know about the feature.
I have filled in the "Changes" section below.
I have filled in the "How did you test this code" section below.

Changes

Closes Add option to choose a project admin when creating a project #6838
Converts CreateProject to TypeScript

Lets the creator assign other users and roles as project administrators directly from the Create Project modal, rather than having to open Project Settings → Members afterwards.

How did you test this code?

Created a project with a non-admin user and a custom role selected; confirmed both appear with admin permission under Project Settings.

Adds a multi-user selector to the create project modal that lets the creator immediately grant project administrator permissions to other users. Selector is only rendered when there are organisation users who would actually benefit — organisation administrators already have full access to every project by default, and the creator is excluded. Reuses the existing UserSelect component. Refs #6838. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Replace the user-only chip selector with a single SettingsButton-backed picker that searches across eligible users, groups, and roles in one list. Selected entries render as chips with the entity type as a sublabel, and submission fans the assignments out to the user, group, and role project-permission endpoints in parallel. Also add an optional 'description' prop to SettingsButton so help text can sit between the label/cog row and the content slot. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Render selected administrators as "User: name" / "Group: name" / "Role: name" with the type label semibold on the left, dropping the muted email/type sublabel that previously sat to the right. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Drop the inline-modal--sm size cap (355px max-width) and set the picker content to a fixed 480px width with a 320px scroll height so the combined list of users / groups / roles has more room. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

font-weight-bold (700) was too heavy; use semibold (600) for the User/Group/Role prefix in the project admin chip. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Render an optional dropdown node between the label/cog row and the description/content. Used by CreateProject to anchor the project administrator picker under the title rather than under the chip list. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Restrict the project administrator picker to users and roles only; remove the group fetch, state, request fan-out, and UI strings. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Replace the unified Inline picker with a Project administrators heading plus two SettingsButtons (Users, Roles), each anchoring its own picker via the SettingsButton dropdown slot. UserSelect and MyRoleSelect handle search and selection. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

OrganisationProvider registers its onSave listener once on mount, so the close function captures the initial empty adminIds/adminRoleIds and never sees the user's selections. Mirror both into refs and read from the refs when fanning out the user-permission / role-projects-permission POSTs after the project is created. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

vercel · 2026-05-22T13:56:08Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
flagsmith-frontend-preview	Ready	Preview, Comment	May 22, 2026 2:36pm
flagsmith-frontend-staging	Ready	Preview, Comment	May 22, 2026 2:36pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Ignored	Preview	May 22, 2026 2:36pm

github-actions · 2026-05-22T13:57:09Z

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-api:pr-7580`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-7580`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-7580`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-api-test:pr-7580`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-e2e:pr-7580`	Finished ✅	Skipped
`ghcr.io/flagsmith/flagsmith-frontend:pr-7580`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-api:pr-7580`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith:pr-7580`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-7580`	Finished ✅	Results ✅
`ghcr.io/flagsmith/flagsmith-frontend:pr-7580`	Finished ✅	Results ✅

gemini-code-assist

Code Review

This pull request refactors the CreateProject modal into a functional component and introduces the ability to assign project administrators and roles during the creation process. It also extends the SettingsButton component with new description and dropdown props. The review feedback identifies a potential stale closure issue with the onSave callback and recommends using a ref to ensure the latest version is called, while also suggesting safer handling of the data object in the close function to avoid destructuring errors.

Drop the raw _data.post calls in favour of two dedicated RTK Query mutations: - createProjectUserPermission (POST /projects/{id}/user-permissions/) added to projectService. - createProjectRolePermission (POST /organisations/{orgId}/roles/{roleId}/ projects-permissions/) added to rolePermissionService — separate from the generic createRolePermissions endpoint so the body type can be scoped to the project case without making project/environment optional on the multi-level type. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

github-actions · 2026-05-22T14:03:29Z

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

1 passed

Details

1 test across 1 suite
41.7 seconds
c8da1dd
🔄 Run: #16930 (attempt 1)

2 tests across 2 suites
32.7 seconds
1863489
🔄 Run: #16942 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

2 passed

Details

2 tests across 2 suites
37.2 seconds
1863489
🔄 Run: #16942 (attempt 1)

github-actions · 2026-05-22T14:03:52Z

Visual Regression

19 screenshots compared. See report for details.
View full report

…ermissions The mutation operates on the project user-permissions resource, so it belongs alongside the other user-permissions endpoint rather than in projectService. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

- Default-destructure data || {} so a null/undefined payload from OrganisationProvider doesn't throw. - Mirror onSave into onSaveRef so the latest parent callback is invoked even if it changes between renders (the listener inside OrganisationProvider is registered once on mount). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Type props (history, onSave), state, refs, and the OrganisationProvider save payload. Import OrganisationProvider and InputGroup explicitly rather than relying on JSX globals. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…name Use Promise.allSettled when assigning project administrators so all mutations attempt regardless of individual failures, and skip navigation/onSave when any fail so the user can retry from the modal. Trim project name on submit to reject whitespace-only inputs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

talissoncosta

Looks good, just some minor suggestions. No blockers.

talissoncosta · 2026-05-22T17:56:58Z

+                          />
+                        }
+                        content={
+                          <Row style={{ rowGap: '12px' }}>


can you please double check if this inline style is still needed ?

talissoncosta · 2026-05-22T18:11:27Z

+      setAssigningAdmins(true)
+      const failures = await assignProjectAdmins(projectId)
+      setAssigningAdmins(false)
+      if (failures) {


If assignProjectAdmins fails, we toast and return — but the project has already been created by OrganisationProvider, so the user ends up stuck on the modal with an invisible orphaned project. Dismissing the modal navigates nowhere; clicking Create again duplicates.

Could we close + navigate on partial failure too, with the toast saying something like "Project created — N admin assignment(s) failed. Retry in Project Settings → Members."? That way the failure becomes a notification rather than a dead end.

talissoncosta · 2026-05-22T18:20:45Z

+        const busy = isSaving || assigningAdmins
+        const showUserSelector = !!eligibleAdmins.length
+        const showRoleSelector = !!hasRbac && !!roles.length
+        const showAdminSelector = showUserSelector || showRoleSelector


When disableCreate is true the form fades, but the admin selectors and chip removals are still interactive behind it. Easiest fix is to unmount the whole block:

Suggested change

const showAdminSelector = showUserSelector || showRoleSelector

const showAdminSelector = (showUserSelector || showRoleSelector) && !disableCreate

Do you mind double check that ?

kyle-ssg and others added 11 commits May 22, 2026 13:10

feat(project-admin): autofocus search when admin picker opens

285d0f9

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

style(project-admin): semibold weight for chip type prefix

cf68fcd

font-weight-bold (700) was too heavy; use semibold (600) for the User/Group/Role prefix in the project admin chip. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

style(project-admin): use fw-semibold class for chip type prefix

91e5822

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

refactor(project-admin): drop group support from admin picker

0529e8a

Restrict the project administrator picker to users and roles only; remove the group fetch, state, request fan-out, and UI strings. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

kyle-ssg requested a review from a team as a code owner May 22, 2026 13:56

kyle-ssg requested review from talissoncosta and removed request for a team May 22, 2026 13:56

kyle-ssg marked this pull request as draft May 22, 2026 13:56

github-actions Bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels May 22, 2026

gemini-code-assist Bot reviewed May 22, 2026

View reviewed changes

Comment thread frontend/web/components/modals/CreateProject.js Outdated

Comment thread frontend/web/components/modals/CreateProject.js Outdated

vercel Bot deployed to Preview – flagsmith-frontend-preview May 22, 2026 14:00 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-staging May 22, 2026 14:00 View deployment

github-actions Bot added feature New feature or request and removed feature New feature or request labels May 22, 2026

vercel Bot deployed to Preview – flagsmith-frontend-staging May 22, 2026 14:06 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-preview May 22, 2026 14:06 View deployment

github-actions Bot added feature New feature or request and removed feature New feature or request labels May 22, 2026

vercel Bot deployed to Preview – flagsmith-frontend-staging May 22, 2026 14:07 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-preview May 22, 2026 14:07 View deployment

github-actions Bot added feature New feature or request and removed feature New feature or request labels May 22, 2026

vercel Bot deployed to Preview – flagsmith-frontend-staging May 22, 2026 14:11 View deployment

github-actions Bot removed the feature New feature or request label May 22, 2026

vercel Bot deployed to Preview – flagsmith-frontend-preview May 22, 2026 14:11 View deployment

github-actions Bot added the feature New feature or request label May 22, 2026

kyle-ssg and others added 2 commits May 22, 2026 15:33

refactor(settings-button): drop unused description prop

c6af069

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

kyle-ssg marked this pull request as ready for review May 22, 2026 14:34

vercel Bot deployed to Preview – flagsmith-frontend-staging May 22, 2026 14:34 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-preview May 22, 2026 14:34 View deployment

github-actions Bot added feature New feature or request and removed feature New feature or request labels May 22, 2026

docs(project-admin): drop groups from admin picker description

1863489

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

vercel Bot deployed to Preview – flagsmith-frontend-staging May 22, 2026 14:36 View deployment

vercel Bot deployed to Preview – flagsmith-frontend-preview May 22, 2026 14:36 View deployment

github-actions Bot added feature New feature or request and removed feature New feature or request labels May 22, 2026

talissoncosta approved these changes May 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: choose project administrators on project creation#7580

feat: choose project administrators on project creation#7580
kyle-ssg wants to merge 18 commits into
mainfrom
feat/project-admin-selector

kyle-ssg commented May 22, 2026 •

edited

Loading

Uh oh!

vercel Bot commented May 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 22, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 22, 2026 •

edited

Loading

Uh oh!

talissoncosta left a comment •

edited

Loading

Uh oh!

talissoncosta May 22, 2026

Uh oh!

talissoncosta May 22, 2026

Uh oh!

talissoncosta May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	const showAdminSelector = showUserSelector \|\| showRoleSelector
	const showAdminSelector = (showUserSelector \|\| showRoleSelector) && !disableCreate

Conversation

kyle-ssg commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

How did you test this code?

Uh oh!

vercel Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docker builds report

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

Details

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

Details

Uh oh!

github-actions Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Visual Regression

Uh oh!

talissoncosta left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

talissoncosta May 22, 2026

Choose a reason for hiding this comment

Uh oh!

talissoncosta May 22, 2026

Choose a reason for hiding this comment

Uh oh!

talissoncosta May 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kyle-ssg commented May 22, 2026 •

edited

Loading

vercel Bot commented May 22, 2026 •

edited

Loading

github-actions Bot commented May 22, 2026 •

edited

Loading

github-actions Bot commented May 22, 2026 •

edited

Loading

github-actions Bot commented May 22, 2026 •

edited

Loading

talissoncosta left a comment •

edited

Loading