Skip to content

Add of the aggregation functionnality #1389

Open
kawkawa99 wants to merge 4 commits into
FreeOpcUa:masterfrom
kawkawa99:main
Open

Add of the aggregation functionnality #1389
kawkawa99 wants to merge 4 commits into
FreeOpcUa:masterfrom
kawkawa99:main

Conversation

@kawkawa99

Copy link
Copy Markdown

The aim of this pull request is to add the functionality of requesting aggregates from the server using the "ReadProcessedDetails" low level function by adding a high level function "Read_processed_history" similar to the "Read_raw_history" high level function.

@oroulet

oroulet commented Aug 13, 2023

Copy link
Copy Markdown
Member

give the MR a sensible name and fix the tests

@kawkawa99

Copy link
Copy Markdown
Author

I have updated the function, what can I do about the tests ?

@oroulet

oroulet commented Aug 22, 2023

Copy link
Copy Markdown
Member

I have updated the function, what can I do about the tests ?

the name of the merge request here is still "first commit"... not very explicit...

The tests? if you click on the failing pipelines over you can see that it is lintingt failing. so try to run "ruff" on you code and fix the errors it gives you

@kawkawa99 kawkawa99 changed the title first commit Add of the aggregation functionnality Aug 22, 2023
@kawkawa99

Copy link
Copy Markdown
Author

I just read the details, but can't figure out how to solve them. can someone help ?

@kawkawa99

Copy link
Copy Markdown
Author

Knowing that I did the tests locally and the function worked with no errors.

@oroulet

oroulet commented Aug 24, 2023

Copy link
Copy Markdown
Member

next step is to install ruff and run it on your code. It show clearly at least one error

@kawkawa99

Copy link
Copy Markdown
Author

I just installed ruff and executed it on the modified script, but it doesn't show any error :
image

@oroulet

oroulet commented Sep 11, 2023

Copy link
Copy Markdown
Member

you have a proble on your system then. but then you can also use the output of the CI on gihub: https://github.com/FreeOpcUa/opcua-asyncio/actions/runs/5936420662/job/16096791948?pr=1389 what needs fixing is quite clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants