basic pubsub#826
Draft
schroeder- wants to merge 33 commits into
Draft
Conversation
oroulet
reviewed
Feb 28, 2022
schroeder-
force-pushed
the
basic_pubsub
branch
from
March 20, 2022 17:17
d90117b to
eb5c29d
Compare
schroeder-
marked this pull request as draft
April 10, 2022 13:05
Contributor
Author
|
So took me sometime to address the api changes. |
- mirror change from mypy - ignore mypy errors - better to fix issues step by step
get_origin, get_args already defined
* Previously a client could not read values with bad status. * This functionality can be toggled on and off. * Added tests. Fixes FreeOpcUa#856
prevents unsupported identity tokens to create a session
MinimumSamplingInterval is from Type Duration/Double so a float. Correct xmlparser.
Comparing 1.04.7 and 1.04.11 failed, use compare list instead of str compare.
Allow fields in structs that are subtype of a class.
- DataSetFieldFlags is only from type UInt16 instead of UInt32 - Default Optionset to UInt32 instead of Int32
- Fix mypy - Fix other errors
Contributor
|
Can we get a rebase and merge of this (even as an unstable API)? PubSub is now used by CODESYS, and it is being adopted by a couple other big vendors. |
Contributor
|
@schroeder- Could you rebase this so we can work on it? |
Member
@alexchandel if you intend to work on that, I think it is faster for you to do the rebase yourself. We never manager to find a very good high level api |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of this pr is just a preview, to gather feedback about the api design. Pubsub is really complex and a lot of things are not implemented or handled correctly.
Points of interests are examples/pubsub/publisher_simple.py and examples/pubsub/publisher_simple.py.
Running both examples creates an publishing server on port 4840 with a folder "PublisherDemoNodes" with variables. This variables are send via uadp-udp, to the subscriber. On port 4841 the subscriber server has a folder "PublisherDemoNodes" where the variables revived via pubsub are mirrored. You can now change the variables on the publisher (Port 4840) and the values will be mirrored on the subscriber.
TODO
implemented features
Messagetypes:
Transportlayer
Informationmodel