[BUGFIX + CHORE] Remove the instrumental resync#7614
Open
realvirtu wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
status: pending triage
NotHyper-474
added
type: minor bug
Contributor
Author
|
Thank you, Hyper. Your labeling is awesome. |
realvirtu
force-pushed
the
fix-song-restart-bug-again
branch
from
7741063 to
0953bfd
Compare
Member
|
I believe all these fixes we've been doing here are all bandaids and the real issue is still with-in lime's NativeAudioSource backend |
Contributor
Author
|
Understandable. Thank you, Karim. |
Member
|
Let's try a change Karim made. |
Hundrec
added
status: rejected
Contributor
Author
|
So I know this is rejected, but knowing Karim's fix doesn't work according to Hyper, do we think this could be needed anyways? |
Member
|
Sure, let's try it out |
Hundrec
added
type: minor bug
Hundrec
added
status: pending triage
realvirtu
force-pushed
the
fix-song-restart-bug-again
branch
from
0953bfd to
9ec4eb9
Compare
Contributor
Author
|
This doesn't work when time traveling. However, I think this is needed still + I'm about to do a PR for Lime that makes this actually work. |
realvirtu
changed the title
Contributor
Author
|
Maybe the name edit wasn't needed, but eh why not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
FunkinCrew/lime#94 is needed for this to work properly
Linked Issues
Fixes #5449
Description
This PR removes the instrumental resync. Why? Because it's unnecessary. The conductor ALWAYS tracks the instrumental time while it's playing, so the instrumental shouldn't be desynced from the chart. This also fixes the song restart bug (like really it shouldn't even exist). I may have been wrong about fixing it before, but this is 100% guaranteed to wipe that bug from existence.
Yes I tested this with a lag spike. It works just fine.
Yes I tested this with a different global offset.