Skip to content

[ENHANCEMENT] Force-reload from runtime Polymod errors#7633

Open
zxcksharks wants to merge 2 commits into
FunkinCrew:developfrom
zxcksharks:reload-polymod-error
Open

[ENHANCEMENT] Force-reload from runtime Polymod errors#7633
zxcksharks wants to merge 2 commits into
FunkinCrew:developfrom
zxcksharks:reload-polymod-error

Conversation

@zxcksharks

Copy link
Copy Markdown

Linked Issues

#7622

Description

This PR allows modders to reload their game from specific runtime Polymod error messages, allowing you to escape traps such as continuous errors during onUpdate() or simply as a faster way to react to small mistakes.

Screenshots/Videos

TBA

We only use showPolymodError on runtime exceptions because allowing reloads during script parsing lets you reload during reloads... which breaks the game
@github-actions github-actions Bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. labels May 26, 2026
@NotHyper-474 NotHyper-474 added type: minor bug Involves a minor bug or issue. topic: mods Related to the creation or use of mods. labels May 26, 2026
@zxcksharks

Copy link
Copy Markdown
Author

I just tested it with an actual script, and it crashes the game...
Implementing this might actually be more complicated than just slapping a forceReloadAssets() onto it, and I kinda don't feel like figuring that out 😭"

@zxcksharks zxcksharks closed this May 26, 2026
@zxcksharks

Copy link
Copy Markdown
Author

this might be the fastest self-rejected pr in history

@NotHyper-474 NotHyper-474 added status: rejected Issue did not pass review or PR cannot be approved. and removed type: minor bug Involves a minor bug or issue. status: pending triage Awaiting review. topic: mods Related to the creation or use of mods. pr: haxe PR modifies game code. labels May 26, 2026
@KT-Gameplay

KT-Gameplay commented May 26, 2026

Copy link
Copy Markdown

It's because selected isnt the right type shit

@zxcksharks

zxcksharks commented May 26, 2026

Copy link
Copy Markdown
Author

It's because selected isnt the right type shit

For a second I thought you meant selected wasn't the right return type, which got me really confused...

(It is, it's an Int return type)

I don't really see this being implemented, especially the way I'm doing it, but I'm putting together a really, really janky solution to getting this working and reopening this PR just in-case someone interested wants to use it for their own personal builds (or, if for some weird reason, it is pulled)

@zxcksharks zxcksharks reopened this May 26, 2026
@github-actions github-actions Bot added the pr: haxe PR modifies game code. label May 26, 2026
@NotHyper-474 NotHyper-474 added type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. topic: mods Related to the creation or use of mods. and removed status: rejected Issue did not pass review or PR cannot be approved. labels May 26, 2026
@Hundrec Hundrec linked an issue May 27, 2026 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: mods Related to the creation or use of mods. type: enhancement Involves an enhancement or new feature.

Development

Successfully merging this pull request may close these issues.

Enhancement: Allow force-reload from Polymod error

3 participants