[BUGFIX] Use ASCII case conversion in AtlasText to fix Turkish-locale glyph misses#7639
Open
VICK-sys wants to merge 1 commit into
Open
[BUGFIX] Use ASCII case conversion in AtlasText to fix Turkish-locale glyph misses#7639VICK-sys wants to merge 1 commit into
VICK-sys wants to merge 1 commit into
Conversation
github-actions
Bot
added
size: medium
Hundrec
added
type: minor bug
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
#6700
Description
Fixes text rendering on Linux + Turkish locale (
tr_TR.UTF-8), where lettersI/i(and similar) failed to render. Reporter independently diagnosed it:LANG=Cmakes it work.AtlasText.restrictCasecallsString.toUpperCase()/toLowerCase(). On hxcpp these go through the C++ stdlib which is locale-aware. In Turkish,"i".toUpperCase()returns"İ"(dotted I) and"I".toLowerCase()returns"ı"(dotless i). The font atlas only has ASCII glyphs, so the lookup misses and the character disappears.Screenshots/Videos