[BUGFIX] Properly mute legacy song voices that use the opponent track#7654
Open
zxcksharks wants to merge 1 commit into
Open
[BUGFIX] Properly mute legacy song voices that use the opponent track#7654zxcksharks wants to merge 1 commit into
zxcksharks wants to merge 1 commit into
Conversation
github-actions
Bot
added
status: pending triage
zxcksharks
changed the title
zxcksharks
changed the title
NotHyper-474
added
type: minor bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
None
Description
Previously, only dropped held notes had checks to properly mute the correct voice track. This PR adds the same check to all parts of the code where voices become muted.
Screenshots/Videos
Before:
voices-before.mp4
After:
video-after.mp4