Skip to content

[ENHANCEMENT] Rework how FunkinGroup changes its children's variables#7753

Open
MightyTheArmiddilo wants to merge 1 commit into
FunkinCrew:developfrom
MightyTheArmiddilo:funkin-group-positioning-rework
Open

[ENHANCEMENT] Rework how FunkinGroup changes its children's variables#7753
MightyTheArmiddilo wants to merge 1 commit into
FunkinCrew:developfrom
MightyTheArmiddilo:funkin-group-positioning-rework

Conversation

@MightyTheArmiddilo

Copy link
Copy Markdown
Contributor

Description

When I first created FunkinGroup, I made it the way it was as I thought the way FlxNestedSprite did it was the only good way to do so. I found the local variables annoying, though, and so did other people I talked to that used it. So I decided to change that.

Now, in draw(), FunkinGroup saves the transformations of its children, applies new transformations like updateChildren() did, draws the children, and reapplies the original saved transformations. This allows for a similar functionality to be used without local variables.

Important

This PR is a breaking change for any mods that use FunkinGroup!! The main thing that mods would need to change would be localX -> x (and those alike). They may also need to change overrides of updateChildren() to positionChildren() or positionChild() or replace the setting of customChildUpdate with the setting of customChildPositioning

Note

While testing this PR, I noticed a bug with the clipRect implementation Kade made, where scale and angle would break the rendering. This isn't caused by this PR as I could cause it without this PR.

@github-actions github-actions Bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. labels Jul 4, 2026
@NotHyper-474 NotHyper-474 added the type: enhancement Involves an enhancement or new feature. label Jul 4, 2026
@MightyTheArmiddilo MightyTheArmiddilo force-pushed the funkin-group-positioning-rework branch from b8d6b32 to 30c4d51 Compare July 6, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: pending triage Awaiting review. type: enhancement Involves an enhancement or new feature.

Development

Successfully merging this pull request may close these issues.

2 participants