[codex] expose context compaction gates (#3765)#3780
Open
nightt5879 wants to merge 2 commits into
Open
Conversation
Add config.toml switches for the two context-maintenance mechanisms from Hmbown#3765: [compaction].enabled controls replacement compaction at the engine layer, and [seam_manager].enabled is an explicit alias for the Flash seam manager master switch. The default path stays compatible: if [compaction].enabled is unset, runtime compaction still follows the existing auto_compact settings/default behavior. Credit: thanks @Mr-Moon121 for the concrete Hmbown#3765 report and config-surface request. Verification: - cargo fmt --all --check - cargo test -p codewhale-tui --bin codewhale-tui --locked compaction - cargo test -p codewhale-tui --bin codewhale-tui --locked seam_manager_enabled - cargo test -p codewhale-tui --bin codewhale-tui --locked profile_without_context_gates - cargo test -p codewhale-tui --bin codewhale-tui --locked config - cargo test --workspace --locked - cargo build --release -p codewhale-cli -p codewhale-tui --locked Signed-off-by: Nightt <87569709+nightt5879@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e80e111713
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Address Codex review feedback on PR Hmbown#3780.\n\nKeep the runtime [compaction].enabled override in sync when config.toml is reloaded or a profile switch loads a new Config, and use the effective automatic compaction gate for the pre-send trigger and context-pressure guidance.\n\nVerification:\n- cargo fmt --all --check\n- cargo test -p codewhale-tui --bin codewhale-tui --locked compaction\n- cargo test --workspace --locked\n- cargo build --release -p codewhale-cli -p codewhale-tui --locked\n\nSigned-off-by: Nightt <nightt5879@users.noreply.github.com>
Owner
|
Thanks @nightt5879. This context-compaction gate work is promising, but it conflicts with current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3765.
[compaction].enabledas an engine-level config.toml switch for replacement compaction.[seam_manager].enabledas an explicit alias for the Flash seam manager master switch while keeping thresholds/model under[context].[compaction].enabledis unset: runtime compaction still follows the savedauto_compactsettings/default path.config.example.tomlanddocs/CONFIGURATION.mdso power users can discover the hard gates.Credit: thanks @Mr-Moon121 for the concrete report and config-surface request in #3765.
Verification
cargo fmt --all --checkcargo test -p codewhale-tui --bin codewhale-tui --locked compactioncargo test -p codewhale-tui --bin codewhale-tui --locked seam_manager_enabledcargo test -p codewhale-tui --bin codewhale-tui --locked profile_without_context_gatescargo test -p codewhale-tui --bin codewhale-tui --locked configcargo test --workspace --lockedcargo build --release -p codewhale-cli -p codewhale-tui --locked