Harden rollout abort and routed experts handling#1827
Open
YanhuiDua wants to merge 3 commits into
Open
Conversation
f2baeba to
b4baa80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 主要修复 rollout pause/abort 在高并发异步 RL 训练中的收尾问题,并拆成三类改动:
增强
abort_request的可靠性train_batch_size * prompt_repeat_k * (1 + over_sample_threshold) / rollout_workers检查所需 HTTP 并发,如果当前allow_over_concurrency_ratio不足,会自动调大并打印 warning。status和finish_reason标记为ABORTED,避免 abort 后完成的 response 被误当成 completed sample,然后继续 judge支持 judger abort
AgentLoop.pause()统一触发 rollout pause 和 judger pause。- 新的修复:不在Judger中定义pause方法,如果在基类写pause方法,没办法做到每个judger都能用,为了简化judger的用法,所以在
SingleTurnAgentLoop中将调用judger作为可取消的修复 routed experts 的返回与清理
return_routed_experts改为同时受全局enable_return_routed_experts和 request-levelsample_params.return_routed_experts控制,评估请求关闭 routed experts 返回。