Skip to content

WI-84821 SNMP2 and SNMP3 stubs $host param should be $hostname#1890

Merged
LolGleb merged 4 commits into
JetBrains:masterfrom
StefNieuwhuis:snmp_stubs
May 11, 2026
Merged

WI-84821 SNMP2 and SNMP3 stubs $host param should be $hostname#1890
LolGleb merged 4 commits into
JetBrains:masterfrom
StefNieuwhuis:snmp_stubs

Conversation

@StefNieuwhuis
Copy link
Copy Markdown

WI-84821 SNMP2 and SNMP3 stubs $host param should be $hostname

Changed $host paramter to $hostname in all snmp2 and snmp3 functions to be consistent with the actual extension.

Stef Nieuwhuis added 3 commits May 7, 2026 12:21
…e to match the parameters in the actual C implementation.
…e to match the parameters in the actual C implementation.
…e to match the parameters in the actual C implementation.
Comment thread PhpStormStubsMap.php
@LolGleb LolGleb self-assigned this May 11, 2026
@LolGleb
Copy link
Copy Markdown
Contributor

LolGleb commented May 11, 2026

Thanks for the PR. A couple of asks before this can land:

  1. Drop the PhpStormStubsMap.php changes please. The proposed map is missing valid mappings;
  2. Fix snmp2_real_walk docblock. Line 601 still says @param string $host while the signature on line 619 was renamed to $hostname;
  3. (Optional) Would you mind covering the snmp1 family too? snmpgetnext, snmprealwalk, and snmpset still use $host in both signature and docblock, and php.net documents them as $hostname. Otherwise the file is left half-converted.

…ock to say . fixed the snmpgetnext, snmprealwalk and snmpset to also use instead of System.Management.Automation.Internal.Host.InternalHost
@LolGleb LolGleb merged commit 9e1bd79 into JetBrains:master May 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants