Fix missing optimization in CodeSinkingPass#6703
Open
diddily wants to merge 1 commit into
Open
Conversation
Set checked_for_uniform_sync_ after the first scan for uniform memory sync instructions which is called for most instructions. This makes the optimization pass O(N) instead of O(N^2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
checked_for_uniform_sync_after the first scan for uniform memory sync instructions inHasUniformMemorySync. Since this function is called for most instructions, this change makes the optimization pass O(N) instead of O(N^2). This drastically reduces how long it takes in complex binaries and fulfills what I assume was the original intent ofchecked_for_uniform_sync_.