[opt] Pass to convert to untyped pointers#6714
Open
alan-baker wants to merge 7 commits into
Open
Conversation
Converts typed pointers instructions to their untyped versions: * OpTypePointer -> OpTypeUntypedPointerKHR * OpVariable -> OpUntypedVariableKHR * OpAccessChain -> OpUntypedAccessChainKHR * OpInBoundsAccessChain -> OpUntypedInBoundsAccessChainKHR * OpCopyMemory * this is decomposed into loads and stores * Updates stride in cooperative matrix load/store Initial support: * StorageBuffer * Uniform Future work: * support workgroup memory explicit layout * add an option to enable workgroup memory explicit layout * support uniform constant for OpUntypedImageTexelPointerEXT * support PhysicalStorageBuffer * support variable pointers
* Fix instruction conversion to avoid bad def/use chains * do in place replacement as much as possible
* Requires all variables to be block-decorated (not just per entry point)
* Fix a bug for adding pre-existing base pointers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts typed pointers instructions to their untyped versions:
Supported storage classes:
Future work: