-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: lift network.ts fs/path behind window.main.timeline IPC bridge #9945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9d09568
updated plan
jackkav b05b06a
feat: lift network.ts fs/path use behind window.main.timeline IPC bridge
jackkav 272de90
fix: address Aikido path-traversal feedback and mock window.main in n…
jackkav c749714
chore: suppress echoServer stdout in playwright config
jackkav 3e8d51d
fix: update insomnia-inso logger for consola v3 compatibility
jackkav 7c8b2a2
refactor: address timeline IPC review concerns
jackkav efc2938
fix: upgrade consola to v3 and fix type/import issues in insomnia-inso
jackkav 8e394ee
fix: restore Node.js-safe fallbacks in network.ts for inso CLI
jackkav 9cac959
fix: sort node: imports before third-party and replace if/else with t…
jackkav 7b07a71
fix: replace static fs/path imports with inline require() to pass ren…
jackkav bea2628
refactor: replace process.type branching in network.ts with build-tim…
jackkav a3746cf
fix: restore object alias format in vite.config.ts to fix rollup build
jackkav 47fa7ae
fix: resolve merge conflicts in logger.ts and cli.ts, restore AGENTS.…
jackkav 4a7b823
remove cx
jackkav 94dce09
fix: add path traversal guard to getTimelinePath in node adapter
jackkav 25c1741
fix tests which use network from main
jackkav ca0cd3b
flake
jackkav b6d6ea6
refactor: replace bundler aliases with process.type runtime detection…
jackkav af8b11b
fix: restore vite alias for network-adapter to fix server bundle build
jackkav fa1a270
feedback
jackkav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,22 @@ | ||
| import type { logType } from 'consola'; | ||
| import consola, { BasicReporter, FancyReporter, LogLevel } from 'consola'; | ||
| import type { ConsolaOptions, LogObject, LogType } from 'consola'; | ||
| import { createConsola } from 'consola'; | ||
|
|
||
| type LogsByType = Partial<Record<logType, string[]>>; | ||
| type LogsByType = Partial<Record<LogType, string[]>>; | ||
|
|
||
| type ModifiedConsola = ReturnType<typeof consola.create> & { __getLogs: () => LogsByType }; | ||
| type ModifiedConsola = ReturnType<typeof createConsola> & { __getLogs: () => LogsByType }; | ||
|
|
||
| const consolaLogger = consola.create({ | ||
| reporters: [ | ||
| new FancyReporter({ | ||
| formatOptions: { | ||
| // @ts-expect-error something is wrong here, ultimately these types come from https://nodejs.org/api/util.html#util_util_inspect_object_options and `date` doesn't appear to be one of the options. | ||
| date: false, | ||
| }, | ||
| }), | ||
| ], | ||
| const consolaLogger = createConsola({ | ||
| formatOptions: { | ||
| date: false, | ||
| }, | ||
| }); | ||
|
|
||
| (consolaLogger as ModifiedConsola).__getLogs = () => ({}); | ||
|
|
||
| export const logger = consolaLogger as ModifiedConsola; | ||
| export { LogLevel, BasicReporter }; | ||
|
|
||
| export class BasicReporter { | ||
| log(logObj: LogObject, _ctx: { options: ConsolaOptions }) { | ||
| process.stdout.write(logObj.args.join(' ') + '\n'); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we ignore the stdout here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because I only enabled it recently, and it was cluttering the smoke test output