chore: add e2e tests for custom lint for OAS#9953
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Playwright smoke coverage for uploading/removing custom Spectral rulesets for OAS design documents, including persistence across relaunch, cloud-sync propagation, and git-sync filesystem mirroring. To enable deterministic uploads in E2E, it introduces a Playwright-only hook to bypass the native file picker dialog.
Changes:
- Add Playwright smoke tests covering custom ruleset upload/remove, relaunch persistence, cloud-sync round-trips, and git-sync
.spectral.yamlmirroring. - Add a Playwright-only
showOpenDialogIPC hook that returns queued dialog results instead of opening a native dialog. - Extend the cloud-sync mock server to support a “Design Project”, multi-user team member keys, and decrypt+unzip blob uploads for persistence.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/insomnia/src/main/ipc/electron.ts | Adds a Playwright-only interception path for showOpenDialog to support deterministic E2E uploads. |
| packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts | New E2E suite validating custom ruleset behavior across relaunch, cloud sync, and git sync. |
| packages/insomnia-smoke-test/server/cloud-sync-api.ts | Enhances the mock cloud-sync API with design project fixtures, multi-user behavior, and blob decryption on upload. |
| packages/insomnia-smoke-test/playwright/test.ts | Extracts a reusable Insomnia launcher and tracks/cleans up multiple Electron app instances per test. |
| packages/insomnia-smoke-test/playwright/pages/insomnia-app.ts | Adds relaunch support and an API to queue showOpenDialog responses via Electron main-process eval. |
| packages/insomnia-smoke-test/fixtures/files/custom.spectral.yaml | Adds a minimal custom Spectral ruleset fixture used by the E2E tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ Circular References ReportGenerated at: 2026-05-26T15:55:28.233Z Summary
Click to view all circular references in PR (19)Click to view all circular references in base branch (19)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
dbb03fe to
4d54dd0
Compare
66bf7be to
3bb5ae0
Compare
3bb5ae0 to
39de451
Compare
No description provided.