feat: add event triggers and request_type for the request_execution event - INS-2235#9957
Draft
ihexxa wants to merge 2 commits into
Draft
feat: add event triggers and request_type for the request_execution event - INS-2235#9957ihexxa wants to merge 2 commits into
ihexxa wants to merge 2 commits into
Conversation
✅ Circular References ReportGenerated at: 2026-05-27T03:24:24.090Z Summary
Click to view all circular references in PR (19)Click to view all circular references in base branch (19)Analysis✅ No Change: This PR does not introduce or remove any circular references. This report was generated automatically by comparing against the |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands AnalyticsEvent.requestExecuted tracking beyond standard HTTP sends by adding execution triggers for gRPC and “connect”-style request types (WebSocket, GraphQL subscription, SSE/Event Stream, Socket.IO), and adds a request_type property to the existing HTTP “request executed” event.
Changes:
- Track
AnalyticsEvent.requestExecutedfrom the gRPC request pane. - Track
AnalyticsEvent.requestExecutedwhen initiating WebSocket / GraphQL subscription / Event Stream / Socket.IO (and MCP) connections. - Add
request_typeto the existing HTTP sendrequestExecutedanalytics payload.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/insomnia/src/ui/components/panes/grpc-request-pane.tsx | Adds requestExecuted tracking for gRPC sends with a request_type property. |
| packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.debug.request.$requestId.send.tsx | Adds request_type to the existing HTTP requestExecuted analytics payload. |
| packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.debug.request.$requestId.connect.tsx | Adds requestExecuted tracking for connect-style requests (WebSocket/GraphQL subscription/SSE/Socket.IO, plus MCP). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c1252e8 to
0778b47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
https://konghq.atlassian.net/browse/INS-2235