Add labelInTitle option to SliderSetting#503
Open
Suor wants to merge 1 commit into
Open
Conversation
Lets a slider render its current value label in the title row instead of next to the slider track, via SliderSetting.setLabelInTitle(true). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any labels longer then several symbols overlap with a control to the right (if slider is in the left column). This is fine for most cases, where labels is a number or a single short word, but lacks flexibility.
This PR adds an optional
labelInTitlemode toSliderSetting. When enabled, the slider's current-value label is rendered in the setting's title row (right-aligned) instead of next to the slider track.API
I tried passing it to constructor, it works but cumbersome without named params, which squirrel lacks and MSU doesn't emulate. Settled on accessor.
Changes
slider_setting.nut: newLabelInTitlefield (defaultfalse),setLabelInTitle(_value)setter, andlabelInTitlepassed throughgetUIData().slider_setting.js: whenlabelInTitleis set, detach the label and append it to thetitleContainer.Default behavior is unchanged (
LabelInTitle = false).