Migration vers .NET 10#7
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to migrate the BrilliantMediator project and all its dependencies from .NET 9 to .NET 10. However, the migration contains numerous critical issues with invalid package versions and an incorrect namespace change that will likely prevent successful compilation.
Key Changes:
- Updated TargetFramework from net9.0 to net10.0 across 7 project files
- Updated Microsoft.Extensions.* packages from 9.0.x to 10.0.0
- Updated third-party packages (Swashbuckle, Serilog, xUnit, etc.) to versions that appear to be invalid
- Changed namespace from Microsoft.OpenApi.Models.OpenApiInfo to Microsoft.OpenApi.OpenApiInfo (likely incorrect)
- Removed Microsoft.AspNetCore.OpenApi package reference
- Added comprehensive migration documentation file
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/BrilliantMediator.Tests/BrilliantMediator.Tests.csproj | Updates test project target framework to net10.0 and test package versions (several invalid versions) |
| src/BrilliantMediator/BrilliantMediator.csproj | Updates main library target framework to net10.0 and Microsoft.Extensions packages to 10.0.0 |
| samples/EcommerceDDD/EcommerceDDD.Infrastructure/EcommerceDDD.Infrastructure.csproj | Updates infrastructure project to net10.0 with Microsoft.Extensions packages to 10.0.0 |
| samples/EcommerceDDD/EcommerceDDD.Domain/EcommerceDDD.Domain.csproj | Updates domain project target framework to net10.0 |
| samples/EcommerceDDD/EcommerceDDD.Application/EcommerceDDD.Application.csproj | Updates application project to net10.0 with Microsoft.Extensions.Logging.Abstractions to 10.0.0 |
| samples/EcommerceDDD/EcommerceDDD.Api/Program.cs | Changes OpenApiInfo namespace (appears incorrect) |
| samples/EcommerceDDD/EcommerceDDD.Api/EcommerceDDD.WebApi.csproj | Updates web API project to net10.0, removes Microsoft.AspNetCore.OpenApi, updates Swashbuckle and Serilog (to invalid versions), and fixes indentation |
| samples/ConsoleApp/ConsoleApp.csproj | Updates console app to net10.0 with Microsoft.Extensions.DependencyInjection to 10.0.0 |
| MIGRATION_NET10.md | Adds comprehensive migration documentation with package version details and troubleshooting information (contains multiple inaccuracies) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| builder.Services.AddSwaggerGen(options => | ||
| { | ||
| options.SwaggerDoc("v1", new Microsoft.OpenApi.Models.OpenApiInfo | ||
| options.SwaggerDoc("v1", new Microsoft.OpenApi.OpenApiInfo |
There was a problem hiding this comment.
The namespace Microsoft.OpenApi.OpenApiInfo appears to be incorrect. The standard namespace for OpenApiInfo in Swashbuckle.AspNetCore and Microsoft.OpenApi packages is Microsoft.OpenApi.Models.OpenApiInfo, not Microsoft.OpenApi.OpenApiInfo. This will likely cause a compilation error. Please verify the correct namespace for the version of Swashbuckle.AspNetCore being used.
Suggested change
| options.SwaggerDoc("v1", new Microsoft.OpenApi.OpenApiInfo | |
| options.SwaggerDoc("v1", new Microsoft.OpenApi.Models.OpenApiInfo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.