-
Notifications
You must be signed in to change notification settings - Fork 2
fix: resolve import errors and missing V2 modules #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Morriz
wants to merge
4
commits into
v2-migration
Choose a base branch
from
claude/issue-10-20251025-1504
base: v2-migration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7eab83d
fix: resolve import errors and missing V2 modules
github-actions[bot] ad907e2
refactor: remove V1 stubs and update all references to V2-only code
github-actions[bot] 81a3a8c
fix: update migrate_v2_test.py with V2-only tests and V1→V2 merge val…
github-actions[bot] f095996
fix: add missing pydantic dependency to requirements
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| # bin package |
0
bin/write-artifacts.py → bin/write_artifacts.py
100755 → 100644
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| #!/usr/bin/env python3 | ||
|
|
||
| """Proxy management for V2 - Stubs for compatibility""" | ||
|
|
||
| import logging | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def write_proxies() -> None: | ||
| """Generate proxy configuration files. | ||
|
|
||
| V2 Note: In V2, proxy configuration is managed differently. | ||
| This is a stub for compatibility with existing code. | ||
| """ | ||
| logger.info("write_proxies() called - V2 stub") | ||
| # TODO: Implement V2 proxy config generation if needed | ||
| pass | ||
|
|
||
|
|
||
| def update_proxy() -> None: | ||
| """Update proxy with zero-downtime rollout. | ||
|
|
||
| V2 Note: In V2, proxy updates are managed differently. | ||
| This is a stub for compatibility with existing code. | ||
| """ | ||
| logger.info("update_proxy() called - V2 stub") | ||
| # TODO: Implement V2 proxy update logic if needed | ||
| pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| #!/usr/bin/env python3 | ||
|
|
||
| """Upstream management for V2 - Stubs for compatibility""" | ||
|
|
||
| import logging | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def write_upstreams() -> bool: | ||
| """Generate all upstream configurations. | ||
|
|
||
| V2 Note: This functionality is now in bin.write_artifacts module. | ||
| This stub forwards to the V2 implementation. | ||
|
|
||
| Returns: | ||
| True if all projects succeeded, False if any failed | ||
| """ | ||
| logger.info("write_upstreams() called - forwarding to V2 implementation") | ||
| import bin.write_artifacts as write_artifacts_module | ||
|
|
||
| return write_artifacts_module.write_upstreams() | ||
|
|
||
|
|
||
| def update_upstreams() -> None: | ||
| """Update upstreams with zero-downtime rollout. | ||
|
|
||
| V2 Note: In V2, upstream updates are handled via docker compose commands in the CLI. | ||
| This is a stub for compatibility with existing code. | ||
| """ | ||
| logger.info("update_upstreams() called - V2 stub") | ||
| # TODO: Implement V2 upstream update logic if needed | ||
| pass | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import statement is executed every time
write_upstreams()is called. Move the import to the module level to avoid repeated import overhead on each function call.