Skip to content

fix: update replicate setup#103

Open
e7mac wants to merge 2 commits into
Music-and-Culture-Technology-Lab:masterfrom
e7mac:master
Open

fix: update replicate setup#103
e7mac wants to merge 2 commits into
Music-and-Culture-Technology-Lab:masterfrom
e7mac:master

Conversation

@e7mac

@e7mac e7mac commented Aug 18, 2023

Copy link
Copy Markdown

This PR bumps the dependencies to get the library working on Replicate
It also updates the prediction function to provide the midi output, and the csv output for chord transcription

@vpavlenko

Copy link
Copy Markdown

Huge thank you for putting this fix together. I'm using https://replicate.com/e7mac/omnizart and it just works

@yoyolicoris

Copy link
Copy Markdown
Member

Hi @e7mac,

Thanks for looking into the Replicate issue!
Could this PR also work without upgrading the tf version? This causes dependency errors in the CI.
I'll have a proper look after it passes the check.

@yoyolicoris
yoyolicoris self-requested a review September 4, 2023 15:20
@e7mac

e7mac commented Sep 5, 2023

Copy link
Copy Markdown
Author

@yoyololicon The TF version definitely needs an update. IIRC, it might work with TF v2.8.0+ but wouldn't work at v2.5.0

@yoyolicoris

yoyolicoris commented Sep 5, 2023

Copy link
Copy Markdown
Member

If so, I suggest opening a separate PR for updating the dependency.
Updating to 2.13 might work for Replicate. But not for the origin package, as it failed the integration check.
(Correct me if I'm wrong, not familiar with Replicate.)
We can merge this after solving the dependency issue.

@yoyolicoris yoyolicoris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did a quick review. I see you changed the predict function to render midi as an option.
Is there a feature request for it? Please link it.
If not, please elaborate on the need for it.

Comment thread cog.yaml
- pip install omnizart
- apt-get update && apt-get install -y fluidsynth
- pip install pyfluidsynth
- pip install git+https://github.com/e7mac/omnizart.git

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to revert this after the dependency update PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants