-
Notifications
You must be signed in to change notification settings - Fork 406
adding vllm unit tests #1517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kinjalpatel27
wants to merge
4
commits into
main
Choose a base branch
from
kinjal/vllm_fq_unit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
adding vllm unit tests #1517
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| FROM vllm/vllm-openai:v0.10.2 | ||
| FROM vllm/vllm-openai:v0.20.0 | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From previous benchmarking, I know 0.20 has an accuracy bug on kimi k2.6. Not sure if it's fixed. 0.19.0 looks safer to me. |
||
|
|
||
| # Set environment variables | ||
| ENV PIP_NO_CACHE_DIR=off \ | ||
|
|
@@ -23,17 +23,11 @@ RUN cd Model-Optimizer && \ | |
| pip install -e ".[all,dev-test]" | ||
|
|
||
| # Llama4 requires this | ||
| RUN pip install flash-attn==2.7.4.post1 | ||
| RUN pip install flash-attn==2.7.4.post1 --no-build-isolation | ||
|
|
||
| # Pre-compile CUDA extensions to avoid compilation time during runtime | ||
| RUN python3 -c "import modelopt.torch.quantization.extensions as ext; ext.precompile()" || true | ||
|
|
||
| # Install requirements from examples (excluding windows examples) | ||
| RUN find Model-Optimizer/examples -name "requirements.txt" | grep -v "windows" | while read req_file; do \ | ||
| echo "Installing from $req_file"; \ | ||
| pip install -r "$req_file" || echo "Warning: Failed to install from $req_file"; \ | ||
| done | ||
|
|
||
| # Allow users to run without root | ||
| RUN chmod -R 777 /workspace | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Set ``VLLM_ALLOW_INSECURE_SERIALIZATION=1`` before vLLM is imported so | ||
| ``LLM.collective_rpc(callable)`` can pickle worker callables. pytest loads | ||
| conftests before sibling test modules, so this beats the top-level | ||
| ``from vllm import LLM`` in ``test_*.py``. | ||
| """ | ||
|
|
||
| import os | ||
|
|
||
| os.environ.setdefault("VLLM_ALLOW_INSECURE_SERIALIZATION", "1") |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.