patch(v2.0): Backport extension service observability and status aggregation fixes#3385
Open
hanyux-nv wants to merge 2 commits into
Open
patch(v2.0): Backport extension service observability and status aggregation fixes#3385hanyux-nv wants to merge 2 commits into
hanyux-nv wants to merge 2 commits into
Conversation
…rvability (NVIDIA#3108) There is a [bug](https://nvbugspro.nvidia.com/bug/6408469) found. `prometheus.scrapeIntervalSeconds: 0` is accepted with response code 201, meaning that the `Min(1)` validation was silently skipped for the zero value. The root cause is because the Go-ozzo validation skips all rules on a field whose value equals the type's zero value unless Required or NotNil is also present. Therefore, when 0 is supplied, ozzo treats the field as empty and skips the `validation.Min(uint32(1))` check. Adding `validation.Required` to force validation to evaluate the field even when its value is 0, so `validation.Min(uint32(1))` now runs correctly. ## Related issues nvbug https://nvbugspro.nvidia.com/bug/6408469 ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [x] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Breaking Changes <!-- If checked, describe the breaking changes and migration steps --> <!-- Breaking changes are not generally permitted, please discuss on a GitHub discussion or with the development team if you believe you need to break a backward compatibility guarantee --> - [ ] **This PR contains breaking changes** ## Testing <!-- How was this tested? Check all that apply --> - [x] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance --> Signed-off-by: Felicity Xu <hanyux@nvidia.com> (cherry picked from commit b83a1de)
…A#3236) Previously, when an image pull failed, the extension service remained in `Pending` with an empty container list. Because image pull failures are not readily exposed through the available CRI commands, the agent could not distinguish a permanent failure from a container that was still starting. To prevent deployments from remaining in `Pending` indefinitely, this PR adds a 10-minute container startup timeout and reports an extension service to be in `Error` when timeout expires. ## Related issues nvbug https://nvbugspro.nvidia.com/bug/5953587 ## Type of Change <!-- Check one that best describes this PR --> - [ ] **Add** - New feature or capability - [ ] **Change** - Changes in existing functionality - [x] **Fix** - Bug fixes - [ ] **Remove** - Removed features or deprecated functionality - [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.) ## Breaking Changes <!-- If checked, describe the breaking changes and migration steps --> <!-- Breaking changes are not generally permitted, please discuss on a GitHub discussion or with the development team if you believe you need to break a backward compatibility guarantee --> - [ ] **This PR contains breaking changes** ## Testing <!-- How was this tested? Check all that apply --> - [x] Unit tests added/updated - [ ] Integration tests added/updated - [ ] Manual testing performed - [ ] No testing required (docs, internal refactor, etc.) ## Additional Notes <!-- Any additional context, deployment notes, or reviewer guidance --> Signed-off-by: Felicity Xu <hanyux@nvidia.com> (cherry picked from commit 6890629)
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
hanyux-nv
requested review from
a team,
jrcichra and
nv-dmendoza
and removed request for
a team and
jrcichra
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-07-10 20:51:20 UTC | Commit: e3e53ab |
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
wminckler
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR cherry-picks commit b83a1de and 6890629 into
release/v2.0.Related issues
Type of Change
Breaking Changes
Testing
Additional Notes