docs(network): document MNNVL rack IP requirements in prerequisites#3399
Open
aswaroop-nv wants to merge 2 commits into
Open
docs(network): document MNNVL rack IP requirements in prerequisites#3399aswaroop-nv wants to merge 2 commits into
aswaroop-nv wants to merge 2 commits into
Conversation
Add control-plane management IP counts for MNNVL racks (switch BMC, two NVOS addresses, and power shelf PMC) so site planners can size OOB pools correctly alongside standard host/DPU nodes. Signed-off-by: Anil Swaroop <aswaroop-nv.nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Summary by CodeRabbit
WalkthroughThe network prerequisites documentation adds the required per-node IP accounting for MNNVL racks, covering the switch BMC, NVOS instances, and power shelf PMC. ChangesNetwork Documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/getting-started/prerequisites/network.md`:
- Line 24: Clarify the table row’s allocation scope by indicating that the three
switch BMC/NVOS addresses are per node, while the single power shelf PMC address
is per rack; state the total as 3N + 1 IPs for a rack with N nodes rather than
implying 4 IPs per node.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b3d9814b-452b-4e4f-a3dc-6f161a39f71f
📒 Files selected for processing (1)
docs/getting-started/prerequisites/network.md
Add control-plane management IP counts for MNNVL racks (switch BMC, two NVOS addresses, and power shelf PMC) so site planners can size OOB pools correctly alongside standard host/DPU nodes. Signed-off-by: Anil Swaroop <aswaroop-nv.nvidia.com> Signed-off-by: Anil Swaroop <aswaroop-nv@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add control-plane management IP counts for MNNVL racks (switch BMC, two NVOS addresses, and power shelf PMC) so site planners can size OOB pools correctly alongside standard host/DPU nodes.
Related issues
Type of Change
Breaking Changes
Testing
Additional Notes
Adds a row to the Control Plane Management Network table for MNNVL racks:
3 IPs per node (switch BMC + 2 NVOS) + 1 (power shelf PMC).