Add suppport for different datatype in stats::mean#3056
Merged
Conversation
Signed-off-by: Mickael Ide <mide@nvidia.com>
lowener
added
enhancement
aamijar
approved these changes
Jun 29, 2026
aamijar
left a comment
aamijar
left a comment
Contributor
There was a problem hiding this comment.
Thanks @lowener, it looks good to me. From my understanding the main change is in the reduction function where we do the cast when reading the data, then do the add and divide ops.
So is the main purpose to calculate the mean in higher precision to avoid floating point errors?
Contributor
Author
|
Yes, the reduction function cast before doing the mean operation, so for example FP16 data can be accumulated in FP32. |
achirkin
approved these changes
Jul 1, 2026
achirkin
left a comment
achirkin
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I've recently encountered a problem this PR will address too: calculating the average graph degree (which is uint32_t).
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the support of two different data types for stats::mean. It will be used in NVIDIA/cuvs#2250
Add support for half in strided dataset. Enabled thanks to this PR: #1585
Closes #2625