Skip to content

[19.0][MIG] hr_timesheet_type_non_billable: Migration to 19.0#922

Open
BhaveshHeliconia wants to merge 23 commits into
OCA:19.0from
HeliconiaIO:19.0-mig-hr_timesheet_type_non_billable
Open

[19.0][MIG] hr_timesheet_type_non_billable: Migration to 19.0#922
BhaveshHeliconia wants to merge 23 commits into
OCA:19.0from
HeliconiaIO:19.0-mig-hr_timesheet_type_non_billable

Conversation

@BhaveshHeliconia

@BhaveshHeliconia BhaveshHeliconia commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

miquelpascual and others added 21 commits May 20, 2026 17:06
@miquelpascual @BhaveshHeliconia
[16.0][ADD] hr_timesheet_type_non_billable: New module hr_timesheet_t…
101f3c2 
…ype_non_billable
@BhaveshHeliconia
[UPD] Update hr_timesheet_type_non_billable.pot
be8a8ed
@OCA-git-bot @BhaveshHeliconia
[BOT] post-merge updates
eb38ee6
@miquelpascual @BhaveshHeliconia
[IMP] hr_timesheet_type_non_billable: pre-commit auto fixes
c7c04b7
@miquelpascual @BhaveshHeliconia
[MIG] hr_timesheet_type_non_billable: Migration to 17.0
215a121
@BhaveshHeliconia
[UPD] Update hr_timesheet_type_non_billable.pot
651a79d
@OCA-git-bot @BhaveshHeliconia
[BOT] post-merge updates
8d1eb69
@mymage @BhaveshHeliconia
Added translation using Weblate (Italian)
2aaecc1
@mymage @BhaveshHeliconia
Translated using Weblate (Italian)
56528b3 
Currently translated at 100.0% (5 of 5 strings)

Translation: timesheet-17.0/timesheet-17.0-hr_timesheet_type_non_billable
Translate-URL: https://translation.odoo-community.org/projects/timesheet-17-0/timesheet-17-0-hr_timesheet_type_non_billable/it/
@miquelpascual @BhaveshHeliconia
[IMP] hr_timesheet_type_non_billable: Now works with helpdesk_ticket too
3a251dd
@BhaveshHeliconia
[UPD] Update hr_timesheet_type_non_billable.pot
c454216
@OCA-git-bot @BhaveshHeliconia
[BOT] post-merge updates
b7ba1ac
@weblate @BhaveshHeliconia
Update translation files
2d90381 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-17.0/timesheet-17.0-hr_timesheet_type_non_billable
Translate-URL: https://translation.odoo-community.org/projects/timesheet-17-0/timesheet-17-0-hr_timesheet_type_non_billable/
@mymage @BhaveshHeliconia
Translated using Weblate (Italian)
22a9506 
Currently translated at 100.0% (6 of 6 strings)

Translation: timesheet-17.0/timesheet-17.0-hr_timesheet_type_non_billable
Translate-URL: https://translation.odoo-community.org/projects/timesheet-17-0/timesheet-17-0-hr_timesheet_type_non_billable/it/
@miquelpascual @BhaveshHeliconia
[17.0][FIX] hr_timesheet_type_non_billable: Fixed dependencies
e31bfaf
@BhaveshHeliconia
[UPD] Update hr_timesheet_type_non_billable.pot
0807bd1
@OCA-git-bot @BhaveshHeliconia
[BOT] post-merge updates
9c67d39
@weblate @BhaveshHeliconia
Update translation files
1e79738 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-17.0/timesheet-17.0-hr_timesheet_type_non_billable
Translate-URL: https://translation.odoo-community.org/projects/timesheet-17-0/timesheet-17-0-hr_timesheet_type_non_billable/
@lbarry-apsl @BhaveshHeliconia
[MIG] hr_timesheet_type_non_billable: Migration to 18.0
ad87e01
@BhaveshHeliconia
[UPD] Update hr_timesheet_type_non_billable.pot
7a50a73
@OCA-git-bot @BhaveshHeliconia
[BOT] post-merge updates
35110f5
@OCA-git-bot OCA-git-bot added series:19.0 mod:hr_timesheet_type_non_billable Module hr_timesheet_type_non_billable labels May 20, 2026
@BhaveshHeliconia BhaveshHeliconia force-pushed the 19.0-mig-hr_timesheet_type_non_billable branch from 798bc63 to 52a1e80 Compare May 20, 2026 11:51
@BhaveshHeliconia BhaveshHeliconia mentioned this pull request May 20, 2026
Open
23 tasks
@BhaveshHeliconia

BhaveshHeliconia commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

@cgarcia-solvos could you review? Thanks!

cgarcia-solvos
cgarcia-solvos reviewed May 29, 2026
View reviewed changes

@cgarcia-solvos cgarcia-solvos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM. Only minor comments:

cgarcia-solvos
cgarcia-solvos reviewed May 29, 2026
View reviewed changes
Comment thread hr_timesheet_type_non_billable/models/project_project.py
cgarcia-solvos
cgarcia-solvos reviewed May 29, 2026
View reviewed changes
Comment thread hr_timesheet_type_non_billable/tests/test_hr_timesheet_type_non_billable.py Outdated
@BhaveshHeliconia BhaveshHeliconia force-pushed the 19.0-mig-hr_timesheet_type_non_billable branch from 52a1e80 to dfa856b Compare June 1, 2026 04:44
@BhaveshHeliconia

BhaveshHeliconia commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

@cgarcia-solvos I've addressed your suggestion. Thanks for the review!

@BhaveshHeliconia

BhaveshHeliconia commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@bosd Could you please review?

@bosd

bosd commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

I'm not so familiar yet with this module. my functional test failed.
Created a project and so (00027) on runboat, registered the following:
0:30 hour billable
0:30 hour non-billale.

When i create a bill from the SO. An invoice is created with 1 hour of billable time.
Was expecting 0:30

@BhaveshHeliconia

BhaveshHeliconia commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

I'm not so familiar yet with this module. my functional test failed. Created a project and so (00027) on runboat, registered the following: 0:30 hour billable 0:30 hour non-billale.

When i create a bill from the SO. An invoice is created with 1 hour of billable time. Was expecting 0:30

@bosd Thanks for the review!

After checking the module, I noticed that no Time Type records were configured for billable and non-billable time. The timesheet entries were created without a Time Type value, and when the invoice was generated from the Sales Order, the full 1 hour was invoiced.

To verify the behavior, I created another Sales Order, S00028, and entered the same timesheets:

0.5 hour billable
0.5 hour non-billable

This time, I explicitly assigned the appropriate Time Type values to the timesheet lines (with the billable/non-billable settings configured). After generating the invoice, only the 0.5 hour billable time was invoiced, which matches the expected behavior.

Could you please check the timesheet entries used in your test and run the flow again, making sure that the Time Type is selected and correctly configured with the billable and non-billable flags?

@bosd

bosd commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@BhaveshHeliconia Thanks for the explanation that works.
So this pr is ok.

Still what confused me is this help text.
Which does not seem to be correct, in combination with this module.
image

sale_timesheet_line_exclude seems to blame.
Edit: Did an isolated test. That module does not work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@cgarcia-solvos cgarcia-solvos cgarcia-solvos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mod:hr_timesheet_type_non_billable Module hr_timesheet_type_non_billable series:19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@BhaveshHeliconia @bosd @cgarcia-solvos @OCA-git-bot @miquelpascual @mymage @weblate @lbarry-apsl