fix: Github checkout#5972
Open
wayfarer3130 wants to merge 4 commits into
Open
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+225
to
+226
| elif [ "$HTTP_CODE" = "422" ]; then | ||
| echo "Release for ${TAG} already exists; treating as success." |
Contributor
There was a problem hiding this comment.
A 422 from the GitHub Releases API means any validation failure (bad JSON, invalid tag format, duplicate name, etc.), not just an already-existing release. Silently treating all 422 responses as success will hide misconfiguration bugs. To be safe, parse the response and check for the specific "already_exists" error code before suppressing the failure.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .circleci/config.yml
Line: 225-226
Comment:
**Overly broad 422 suppression**
A 422 from the GitHub Releases API means *any* validation failure (bad JSON, invalid tag format, duplicate name, etc.), not just an already-existing release. Silently treating all 422 responses as success will hide misconfiguration bugs. To be safe, parse the response and check for the specific `"already_exists"` error code before suppressing the failure.
How can I resolve this? If you propose a fix, please make it concise.
sedghi
reviewed
Apr 21, 2026
| '--message', | ||
| `chore(version): Update package versions to ${nextVersion} [skip ci]`, | ||
| '--conventional-commits', | ||
| '--create-release', |
Member
There was a problem hiding this comment.
so why is this not working anymore?
Contributor
Author
There was a problem hiding this comment.
Updated lerna version
Contributor
Author
There was a problem hiding this comment.
Might also be missing GH_TOKEN, which is a silent failure in newer lerna versions.
Viewers
 |
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/github-publish
|
| Run status |
|
| Run duration | 02m 15s |
| Commit |
|
| Committer | Bill Wallace |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
0
|
 |
0
|
 |
37
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Github releases are not properly supported by lerna any longer
No functional change
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment
Greptile Summary
This PR replaces lerna's broken GitHub release support with a direct
curlcall to the GitHub Releases API in the CircleCI publish job, and removes--create-release githubfrom the lerna version invocation inpublish-version.mjs. The shell script is well-guarded (checks forGH_TOKENandversion.txt) and the tag is pushed bypublish-version.mjsbefore this step runs, so ordering is correct.Confidence Score: 5/5
Safe to merge — the change is a straightforward replacement of broken lerna release support with a direct GitHub API call, with no functional regressions.
Only P2 findings present (redundant body field with generate_release_notes). The core logic is correct: tag is pushed before the release step, guards for missing env vars and version.txt are in place, and error cases exit non-zero.
No files require special attention.
Important Files Changed
Prompt To Fix All With AI
Reviews (4): Last reviewed commit: "Merge remote-tracking branch 'origin/mas..." | Re-trigger Greptile