Feature/fhircast#5988
Conversation
❌ Deploy Preview for ohif-dev failed. Why did it fail? →
|
| }, | ||
| { | ||
| "packageName": "@ohif/extension-nof-ohif-viewer", | ||
| "version": "0.0.1" |
There was a problem hiding this comment.
New extension not installed as a dependency
@ohif/extension-nof-ohif-viewer@0.0.1 is registered here but is absent from package.json and yarn.lock. The OHIF plugin loader will try to resolve this package at build time and fail with a module-not-found error. The package must be added to the relevant package.json (and yarn.lock updated via yarn install) before this entry is usable.
Prompt To Fix With AI
This is a comment left during a code review.
Path: platform/app/pluginConfig.json
Line: 68-71
Comment:
**New extension not installed as a dependency**
`@ohif/extension-nof-ohif-viewer@0.0.1` is registered here but is absent from `package.json` and `yarn.lock`. The OHIF plugin loader will try to resolve this package at build time and fail with a module-not-found error. The package must be added to the relevant `package.json` (and `yarn.lock` updated via `yarn install`) before this entry is usable.
How can I resolve this? If you propose a fix, please make it concise.| "packageName": "@ohif/mode-ultrasound-pleura-bline", | ||
| "version": "3.0.0" | ||
| }, |
There was a problem hiding this comment.
Mode missing
version field and not installed as a dependency
node-on-fhir has no version field, unlike every other extension and mode in this file (all of which declare a semver version). Additionally, this package does not appear in package.json or yarn.lock, so the build will fail to resolve it. A version should be added and the package installed.
| "packageName": "@ohif/mode-ultrasound-pleura-bline", | |
| "version": "3.0.0" | |
| }, | |
| { | |
| "packageName": "node-on-fhir", | |
| "version": "0.0.1" | |
| } |
Prompt To Fix With AI
This is a comment left during a code review.
Path: platform/app/pluginConfig.json
Line: 104-106
Comment:
**Mode missing `version` field and not installed as a dependency**
`node-on-fhir` has no `version` field, unlike every other extension and mode in this file (all of which declare a semver version). Additionally, this package does not appear in `package.json` or `yarn.lock`, so the build will fail to resolve it. A `version` should be added and the package installed.
```suggestion
{
"packageName": "node-on-fhir",
"version": "0.0.1"
}
```
How can I resolve this? If you propose a fix, please make it concise.d0ccfa1 to
8140baf
Compare
…OHIF#5914) Co-authored-by: sedghi <ar.sedghi@gmail.com>
…e API to add and remove persisted bindings. (OHIF#5989) * Reset crosshair modifier to default when resetting user preferences. * Apply bindings when loading persisted bindings.
Patch axios security vulnerabilities.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Context
FHIRCast Minimum Viable Demo (MVD)
Majority of feature exists in the following extension:
https://github.com/node-on-fhir/nof-ohif-viewer
However, changes to websockets and addition of a FHIR datastore are required. Staging here as a draft pull request, so we can have architecture review and discussion.
Changes & Results
Here's a summary of the changes:
platform/app/.env
platform/app/.webpack/webpack.pwa.js
platform/app/pluginConfig.json
platform/app/public/config/default.js
Overall: This commit integrates a "Node on FHIR" extension and mode into OHIF, adding SMART on FHIR client configuration, a FHIR proxy for local development, and the necessary plugin/data-source registrations.
OHIF Preferences panels supports SMART registration
RIS reading worklist supports a SMART Launch functionality
OHIF extension receives the SMART Launch URL and fetches the FHIR data; Subscribe to FHIRcast
RIS updates the underlying ImagingStudy status; event bus triggers FHIRCast
OHIF receives events via FHIRCast
Testing
3a.. See the following RIS Installation Instructions for a more detailed walkthrough.
3b.
Install OHIF with FHIR Datastore and FHIRCast
5.a Register a new user
5.b Load a Synthea sample patient in with the data-importer
5.c Select the patient from the Patient Directory
5.d Use the Order Entry page to add an XR order
5.e Go to the Tech Worklist, start and complete the exam; attach a .dcm file
5.f Go to the Reading Worklist, launch the exam in OHIF
Back in OHIF
6.a Verify that dicom image loads
6.b Subscribe to the patient (third tab)
RIS again
7.a. Read the exam; finalize
Very that OHIF receives the event
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment