Skip to content

Fix: Segmentation "Hide All" fails when switching from 2D to 3D four-… #5995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nithin-trenser wants to merge 3 commits into
base: master
Choose a base branch
from
+12 −5
Open

Fix: Segmentation "Hide All" fails when switching from 2D to 3D four-… #5995

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c21f76a
Fix: Segmentation "Hide All" fails when switching from 2D to 3D four-…
nithin-trenser May 6, 2026
f360e3b
Update based on the review comment on segmentation load in 3d fourup
nithin-trenser May 6, 2026
498b11c
Merge branch 'master' into fix-seg-load-3d-hide-error
Belbin-GK May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions ...nsions/cornerstone/src/services/SyncGroupService/createHydrateSegmentationSynchronizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,16 @@ const segmentationRepresentationModifiedCallback = async (
}

// Ensure the segmentation representation aligns with the target viewport type.
const type: Enums.SegmentationRepresentations =
viewport.type === CoreEnums.ViewportType.VOLUME_3D
? Enums.SegmentationRepresentations.Surface
: ((segmentationRepresentationType as Enums.SegmentationRepresentations) ??
Enums.SegmentationRepresentations.Labelmap);
const is3D = viewport.type === CoreEnums.ViewportType.VOLUME_3D;
const requestedRepresentation =
segmentationRepresentationType as Enums.SegmentationRepresentations;
const { Surface, Contour, Labelmap } = Enums.SegmentationRepresentations;

const type: Enums.SegmentationRepresentations = is3D
? Surface
: requestedRepresentation === Contour
? Contour
: Labelmap;
Comment thread
nithin-trenser marked this conversation as resolved.
Outdated

await segmentationService.addSegmentationRepresentation(targetViewportId, {
segmentationId,
Expand Down
Loading