Skip to content

fix(DICOMMetadata): prevent crash when PixelMeasuresSequence is empty #6016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vishal112222 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(DICOMMetadata): prevent crash when PixelMeasuresSequence is empty #6016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/cornerstone-dicom-seg/src/viewports/OHIFCornerstoneSEGViewport.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ function _getReferencedDisplaySetMetadata(referencedDisplaySet, segDisplaySet) {

const PixelMeasures = Array.isArray(PixelMeasuresSequence)
? PixelMeasuresSequence[0]
: PixelMeasuresSequence;
: PixelMeasuresSequence || {};
Comment on lines 295 to +297
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 The || {} fallback is applied to the non-array branch, but the crash described in the PR occurs when PixelMeasuresSequence is an array — specifically an empty one. When PixelMeasuresSequence = [], Array.isArray([]) is true, so the true branch is taken: PixelMeasuresSequence[0] evaluates to undefined, and then const { SpacingBetweenSlices, SliceThickness } = undefined still throws a TypeError. The fix must guard the true (array) branch as well.

Suggested change
const PixelMeasures = Array.isArray(PixelMeasuresSequence)
? PixelMeasuresSequence[0]
: PixelMeasuresSequence;
: PixelMeasuresSequence || {};
const PixelMeasures = Array.isArray(PixelMeasuresSequence)
? PixelMeasuresSequence[0] || {}
: PixelMeasuresSequence || {};
Prompt To Fix With AI 
This is a comment left during a code review.
Path: extensions/cornerstone-dicom-seg/src/viewports/OHIFCornerstoneSEGViewport.tsx
Line: 295-297

Comment:
The `|| {}` fallback is applied to the **non-array** branch, but the crash described in the PR occurs when `PixelMeasuresSequence` **is** an array — specifically an empty one. When `PixelMeasuresSequence = []`, `Array.isArray([])` is `true`, so the true branch is taken: `PixelMeasuresSequence[0]` evaluates to `undefined`, and then `const { SpacingBetweenSlices, SliceThickness } = undefined` still throws a `TypeError`. The fix must guard the true (array) branch as well.

```suggestion
  const PixelMeasures = Array.isArray(PixelMeasuresSequence)
    ? PixelMeasuresSequence[0] || {}
    : PixelMeasuresSequence || {};
```

How can I resolve this? If you propose a fix, please make it concise.


const { SpacingBetweenSlices, SliceThickness } = PixelMeasures;

Expand Down