Tests/duplicated contour navigation issue#6033
Draft
diattamo wants to merge 19 commits into
Draft
Conversation
…ents-interactions-duplicate
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
❌ Deploy Preview for ohif-dev failed. Why did it fail? →
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…ithub.com/diattamo/Viewers into tests/duplicated-contour-navigation-issue
Contributor
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
Contributor
Author
|
@jbocce @GhadeerAlbattarni fyi I created this PR off of the changes I was making in the duplicate testing. I have it marked as a draft right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR adds coverage for issue #6030.
It's temporarily skipped until issue is fixed.
The skipped test checks that selecting a duplicated contour navigates to the same instance number as the original contour and confirms geometry parity via matching SVG path data.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment
Greptile Summary
This PR cleans up two previously-flagged issues (the deep
getSvgAttributeimport and unusedpagefixtures) and preserves test coverage for issue #6030 by adding atest.skipthat documents the expected instance-navigation and SVG-geometry parity behaviour for duplicated contour segments.getSvgAttributeis now correctly sourced from./utils, and both unusedpagefixture destructurings have been removed from the non-skipped tests.test.skipblock captures the full scenario: clicking the original segment, duplicating it, navigating away, then verifying the duplicated segment navigates back to the same instance and renders the same SVG path data.Confidence Score: 5/5
Safe to merge — the only active changes are a corrected utility import and removal of unused fixtures; the new test is fully skipped and cannot affect CI.
The non-skipped changes are mechanical cleanup with no runtime impact. The skipped test adds documentation value but runs no code in CI until re-enabled.
No files require special attention beyond the skipped test's known assertion gaps, which were already flagged in prior review threads.
Important Files Changed
getSvgAttributedeep import and removes two unusedpagefixtures; adds a newtest.skipthat documents the expected navigation behaviour for duplicated contour segments.Reviews (4): Last reviewed commit: "code review updates" | Re-trigger Greptile