Added Opening Brace as trigger character for formatAfterKeyStroke

[akshita31]

Issue : dotnet/vscode-csharp#1591

Added { as trigger character for formatting changes request.

Please review : @DustinCampbell @TheRealPiotrP @rchande

[akshita31]

omnisharp-vscode side : dotnet/vscode-csharp#1906

[DustinCampbell]

I'm a little worried about this change. What happens in the following case?

1. Set "editor.autoClosingBrackets": false in the VS Code settings.
2. Start with this code;

   class C
   {
       void M1()
       $$
   
       void M2()
       {
       }
   }

3. Type { at the caret position ($$)

Does the declaration of M2() get indented? If so, this might not be the right approach.

[akshita31]

It doesn't indent M2()

[DustinCampbell]

Thanks for verifying the behavior

[akshita31]

Just noticed a problem with this change. After the format the caret symbol should appear just before the closing brace so that on hitting enter we have a proper indentation

[DustinCampbell]

Maybe debug and see if it's got the correct span for the format?

[akshita31]

Tried to edit the span on hitting enter (for this particular case) to include three lines - the previous line(opening brace) , the current line and the nextLine (closing brace), but doing that deletes the spaces in the current line.

I think this is related to auto-indent in vscode. Hence I have filed a bug in vscode here

cc @rchande

[gabrieldechichi]

Any updates on this?