Remove OmniSharpSymbolRenamedCodeActionOperationFactoryWorkspaceService - #2529
Open
Cosifne wants to merge 3 commits into
Open
Remove OmniSharpSymbolRenamedCodeActionOperationFactoryWorkspaceService#2529Cosifne wants to merge 3 commits into
Cosifne wants to merge 3 commits into
Conversation
Member
|
@Cosifne I believe we will need to remove https://github.com/dotnet/roslyn/blob/main/src/Tools/ExternalAccess/OmniSharp/CodeRefactorings/WorkspaceServices/IOmniSharpSymbolRenamedCodeActionOperationFactoryWorkspaceService.cs#L9 from the EA library before we can merge this change. Otherwise our MEF composition doesn't work. |
Author
|
@JoeRobich |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roslyn use
ISymbolRenamedCodeActionOperationFactoryWorkspaceServiceto do extra work when rename.And O# provides the implementation in the extern layer
OmniSharpSymbolRenamedCodeActionOperationFactoryWorkspaceServiceHowever, this looks like wrong, because O# is just create an unnecessary rename action.
This would be cleaned by this change dotnet/roslyn#68095