Skip to content

ci(coverage): adding mandatory 80% level of coverage for diff (#239)#288

Merged
guzmud merged 5 commits into
mainfrom
ci/239-minimum-coverage-for-new-code
Jun 29, 2026
Merged

ci(coverage): adding mandatory 80% level of coverage for diff (#239)#288
guzmud merged 5 commits into
mainfrom
ci/239-minimum-coverage-for-new-code

Conversation

@guzmud

@guzmud guzmud commented Jun 12, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • Adding mandatory 80% level of coverage for diff
  • Adding export and upload of junit.xml
  • More details regarding quality control in CONTRIBUTING.md

Testing Instructions

  1. Run the CI pipeline

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Copilot AI review requested due to automatic review settings June 12, 2026 09:57
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   77.60%   79.65%   +2.04%     
==========================================
  Files          57       57              
  Lines        2541     2541              
==========================================
+ Hits         1972     2024      +52     
+ Misses        569      517      -52     

see 5 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@guzmud guzmud changed the title Ci/239 minimum coverage for new code ci(coverage): adding mandatory 80% level of coverage for diff (#239) Jun 12, 2026
@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Jun 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces Codecov configuration and CI workflow updates to enforce a minimum coverage threshold on new/changed code, publish test results, and document the project’s quality gates for contributors.

Changes:

  • Add codecov.yml to enforce a patch (diff) coverage target of 80%.
  • Update the coverage GitHub Actions workflow to generate junit.xml and upload test results to Codecov.
  • Document CI quality checks and add junit.xml to .gitignore.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.

File Description
CONTRIBUTING.md Documents CI code-quality and coverage expectations for contributors.
codecov.yml Configures Codecov status checks (project informational, patch target 80%).
.gitignore Ignores generated junit.xml.
.github/workflows/coverage.yml Generates JUnit XML output and uploads coverage/test results to Codecov.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread codecov.yml
Comment thread .github/workflows/coverage.yml
Comment thread CONTRIBUTING.md
Comment thread CONTRIBUTING.md
@guzmud guzmud force-pushed the ci/239-minimum-coverage-for-new-code branch 2 times, most recently from 8c6135a to 35a9778 Compare June 15, 2026 14:15
Comment thread codecov.yml
Comment thread .github/workflows/coverage.yml

- name: Print coverage summary
run: uv run coverage report -m --fail-under=70
run: uv run coverage report -m --fail-under=80

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: If you want to enforce this score, it would be better to set fail-under setting inside pyproject.toml

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good call, fixed in 860cd84.

Comment thread .github/workflows/coverage.yml Outdated
with:
token: ${{ secrets.CODECOV_TOKEN }}
flags: connectors
flags: pyoaev

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: This flags is not needed because everything is pyoaev in this repos

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted, thanks, fixed in 860cd84.

@guzmud guzmud force-pushed the ci/239-minimum-coverage-for-new-code branch from 35a9778 to 860cd84 Compare June 29, 2026 08:59
@guzmud guzmud force-pushed the ci/239-minimum-coverage-for-new-code branch from 860cd84 to 8cd881f Compare June 29, 2026 10:34
@guzmud guzmud force-pushed the ci/239-minimum-coverage-for-new-code branch from 8cd881f to 1a66a95 Compare June 29, 2026 10:35
@guzmud guzmud merged commit 11b9780 into main Jun 29, 2026
12 of 13 checks passed
@guzmud guzmud deleted the ci/239-minimum-coverage-for-new-code branch June 29, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: ensure minimum coverage level for new code

4 participants