fix(sekoia): add timeouts for requests (#6813)#6814
Open
axelfahy wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## master #6814 +/- ##
===========================================
- Coverage 34.80% 0.23% -34.58%
===========================================
Files 2008 1916 -92
Lines 123164 120566 -2598
===========================================
- Hits 42870 284 -42586
- Misses 80294 120282 +39988
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses connector hangs by ensuring outbound HTTP calls in the SEKOIA external-import connector use a request timeout, so the connector doesn’t block indefinitely when the upstream API stops responding.
Changes:
- Added a
timeoutto the connector’srequests.get(...)calls via_send_request. - Introduced additional caller-side handling in some places to skip failed ID chunks / file downloads instead of stopping processing.
- Ensured
_runreturns a cursor at the end (but currently with redundant conditional logic).
Comment on lines
206
to
+210
| self.helper.set_state({"last_cursor": cursor}) | ||
| if len(items) < self.limit: | ||
| # We got the last results | ||
| return cursor | ||
| return cursor |
Comment on lines
472
to
+478
| except RequestException as ex: | ||
| if ex.response: | ||
| error = f"Request failed with status: {ex.response.status_code}" | ||
| self.helper.connector_logger.error(error) | ||
| else: | ||
| self.helper.connector_logger.error(str(ex)) | ||
| return None | ||
| raise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments