Skip to content

feat(reversinglabs-spectra-intel-submission): add to catalog (#6836)#6887

Open
throuxel wants to merge 1 commit into
masterfrom
feat/6836-migrate-reversinglabs-spectra-intel-submission
Open

feat(reversinglabs-spectra-intel-submission): add to catalog (#6836)#6887
throuxel wants to merge 1 commit into
masterfrom
feat/6836-migrate-reversinglabs-spectra-intel-submission

Conversation

@throuxel

@throuxel throuxel commented Jul 1, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • add connector to catalog

Related issues

Checklist

  • I consider the submitted work as finished
  • I have signed my commits using GPG key.
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Tested without creds

@throuxel throuxel self-assigned this Jul 1, 2026
Copilot AI review requested due to automatic review settings July 1, 2026 12:35
@throuxel throuxel added the filigran team Item from the Filigran team. label Jul 1, 2026
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.42512% with 346 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pectra-intel-submission/src/connector/connector.py 12.16% 332 Missing ⚠️
...reversinglabs-spectra-intel-submission/src/main.py 0.00% 12 Missing ⚠️
...rsinglabs-spectra-intel-submission/src/__init__.py 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b271dce) and HEAD (e2095c9). Click for more details.

HEAD has 125 uploads less than BASE
Flag BASE (b271dce) HEAD (e2095c9)
connectors 129 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6887       +/-   ##
===========================================
- Coverage   34.89%    0.29%   -34.61%     
===========================================
  Files        2010     1922       -88     
  Lines      123240   120648     -2592     
===========================================
- Hits        43005      352    -42653     
- Misses      80235   120296    +40061     
Files with missing lines Coverage Δ
...spectra-intel-submission/src/connector/__init__.py 100.00% <100.00%> (ø)
...spectra-intel-submission/src/connector/settings.py 100.00% <100.00%> (ø)
...rsinglabs-spectra-intel-submission/src/__init__.py 0.00% <0.00%> (ø)
...reversinglabs-spectra-intel-submission/src/main.py 0.00% <0.00%> (ø)
...pectra-intel-submission/src/connector/connector.py 12.16% <12.16%> (ø)

... and 1174 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the ReversingLabs Spectra Intel Submission internal-enrichment connector to the OpenCTI connectors catalog, updating it to use connectors-sdk settings/contracts and adding a basic test suite to validate configuration and instantiation.

Changes:

  • Refactors the connector entrypoint and configuration to connectors-sdk (BaseConnectorSettings) and adds generated config schema/docs for catalog compatibility.
  • Moves the connector logic into src/connector/connector.py and updates container/compose paths and environment variable names accordingly.
  • Adds pytest coverage for settings validation and basic instantiation of the helper/connector.

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
internal-enrichment/reversinglabs-spectra-intel-submission/src/main.py New lightweight entrypoint wiring settings → helper → connector run().
internal-enrichment/reversinglabs-spectra-intel-submission/src/connector/connector.py Connector logic moved/refactored into a class using ConnectorSettings + OpenCTIConnectorHelper.
internal-enrichment/reversinglabs-spectra-intel-submission/src/connector/settings.py Introduces connectors-sdk config models and connector-specific settings.
internal-enrichment/reversinglabs-spectra-intel-submission/src/connector/init.py Exposes connector classes for convenient imports.
internal-enrichment/reversinglabs-spectra-intel-submission/src/init.py Exposes ConnectorSettings at package level.
internal-enrichment/reversinglabs-spectra-intel-submission/src/config.yml.sample Adds catalog-style YAML sample config for the new settings layout.
internal-enrichment/reversinglabs-spectra-intel-submission/requirements.txt Adds connectors-sdk and pydantic requirement for the new settings/models.
internal-enrichment/reversinglabs-spectra-intel-submission/Dockerfile Updates workdir/path to the new connector directory name (keeps git install).
internal-enrichment/reversinglabs-spectra-intel-submission/entrypoint.sh Updates working directory path before running main.py.
internal-enrichment/reversinglabs-spectra-intel-submission/docker-compose.yml Updates env var names to match the new connectors-sdk config mapping.
internal-enrichment/reversinglabs-spectra-intel-submission/metadata/connector_manifest.json Sets manager_supported: true for catalog/manager compatibility.
internal-enrichment/reversinglabs-spectra-intel-submission/metadata/connector_config_schema.json Adds generated env-var JSON schema contract for catalog.
internal-enrichment/reversinglabs-spectra-intel-submission/metadata/CONNECTOR_CONFIG_DOC.md Adds generated human-readable configuration documentation.
internal-enrichment/reversinglabs-spectra-intel-submission/tests/conftest.py Adds test-time sys.path setup to import connector code from src/.
internal-enrichment/reversinglabs-spectra-intel-submission/tests/test_main.py Adds instantiation tests for settings, helper, and connector.
internal-enrichment/reversinglabs-spectra-intel-submission/tests/tests_connector/test_settings.py Adds validation tests for settings parsing and error handling.
internal-enrichment/reversinglabs-spectra-intel-submission/tests/tests_connector/init.py Initializes the test package.
internal-enrichment/reversinglabs-spectra-intel-submission/tests/test-requirements.txt Adds pytest requirements for running the connector tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(ReversingLabs Spectra Intel Submission): migrate connector to the catalog

3 participants