feat(reversinglabs-spectra-intel-submission): add to catalog (#6836)#6887
Open
throuxel wants to merge 1 commit into
Open
feat(reversinglabs-spectra-intel-submission): add to catalog (#6836)#6887throuxel wants to merge 1 commit into
throuxel wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6887 +/- ##
===========================================
- Coverage 34.89% 0.29% -34.61%
===========================================
Files 2010 1922 -88
Lines 123240 120648 -2592
===========================================
- Hits 43005 352 -42653
- Misses 80235 120296 +40061
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the ReversingLabs Spectra Intel Submission internal-enrichment connector to the OpenCTI connectors catalog, updating it to use connectors-sdk settings/contracts and adding a basic test suite to validate configuration and instantiation.
Changes:
- Refactors the connector entrypoint and configuration to
connectors-sdk(BaseConnectorSettings) and adds generated config schema/docs for catalog compatibility. - Moves the connector logic into
src/connector/connector.pyand updates container/compose paths and environment variable names accordingly. - Adds pytest coverage for settings validation and basic instantiation of the helper/connector.
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| internal-enrichment/reversinglabs-spectra-intel-submission/src/main.py | New lightweight entrypoint wiring settings → helper → connector run(). |
| internal-enrichment/reversinglabs-spectra-intel-submission/src/connector/connector.py | Connector logic moved/refactored into a class using ConnectorSettings + OpenCTIConnectorHelper. |
| internal-enrichment/reversinglabs-spectra-intel-submission/src/connector/settings.py | Introduces connectors-sdk config models and connector-specific settings. |
| internal-enrichment/reversinglabs-spectra-intel-submission/src/connector/init.py | Exposes connector classes for convenient imports. |
| internal-enrichment/reversinglabs-spectra-intel-submission/src/init.py | Exposes ConnectorSettings at package level. |
| internal-enrichment/reversinglabs-spectra-intel-submission/src/config.yml.sample | Adds catalog-style YAML sample config for the new settings layout. |
| internal-enrichment/reversinglabs-spectra-intel-submission/requirements.txt | Adds connectors-sdk and pydantic requirement for the new settings/models. |
| internal-enrichment/reversinglabs-spectra-intel-submission/Dockerfile | Updates workdir/path to the new connector directory name (keeps git install). |
| internal-enrichment/reversinglabs-spectra-intel-submission/entrypoint.sh | Updates working directory path before running main.py. |
| internal-enrichment/reversinglabs-spectra-intel-submission/docker-compose.yml | Updates env var names to match the new connectors-sdk config mapping. |
| internal-enrichment/reversinglabs-spectra-intel-submission/metadata/connector_manifest.json | Sets manager_supported: true for catalog/manager compatibility. |
| internal-enrichment/reversinglabs-spectra-intel-submission/metadata/connector_config_schema.json | Adds generated env-var JSON schema contract for catalog. |
| internal-enrichment/reversinglabs-spectra-intel-submission/metadata/CONNECTOR_CONFIG_DOC.md | Adds generated human-readable configuration documentation. |
| internal-enrichment/reversinglabs-spectra-intel-submission/tests/conftest.py | Adds test-time sys.path setup to import connector code from src/. |
| internal-enrichment/reversinglabs-spectra-intel-submission/tests/test_main.py | Adds instantiation tests for settings, helper, and connector. |
| internal-enrichment/reversinglabs-spectra-intel-submission/tests/tests_connector/test_settings.py | Adds validation tests for settings parsing and error handling. |
| internal-enrichment/reversinglabs-spectra-intel-submission/tests/tests_connector/init.py | Initializes the test package. |
| internal-enrichment/reversinglabs-spectra-intel-submission/tests/test-requirements.txt | Adds pytest requirements for running the connector tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments
Tested without creds