refactor: Replace Arduino WiFi Manager with esp native by hhvrc · Pull Request #314 · OpenShock/Firmware

hhvrc · 2024-11-12T16:08:22Z

No description provided.

changeset-bot · 2025-09-20T15:14:52Z

⚠️ No Changeset found

Latest commit: b2ba84d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Take develop's WiFiManager and WiFiScanManager (headers + sources) to pick up all recent features (auth mode validation, BSSID pinning, disconnect reasons, cooperative shutdown, etc.). Rename WiFiManagerNew.cpp to .wip to exclude from build — the ESP-IDF migration is incomplete and conflicts with the current Arduino-based WiFiManager. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-26T23:53:56Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v21.1.8) reports: 147 concern(s)

include/config/Config.h:1:1: warning: [portability-avoid-pragma-once]

avoid 'pragma once' directive; use include guards instead
```
    1 | #pragma once
      | ^
```
include/config/Config.h:23:15: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
   23 |   std::string GetAsJSON(bool withSensitiveData);
      |               ^
```

include/config/Config.h:24:8: warning: [modernize-use-trailing-return-type]

   24 |   bool SaveFromJSON(std::string_view json);
      |   ~~~~ ^                                  
      |   auto                                     -> bool

include/config/Config.h:27:78: warning: [modernize-use-trailing-return-type]

   27 |   [[nodiscard]] flatbuffers::Offset<Serialization::Configuration::HubConfig> GetAsFlatBuffer(flatbuffers::FlatBufferBuilder& builder, bool withSensitiveData);
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^                                                                               
      |                 auto                                                                                                                                          -> flatbuffers::Offset<Serialization::Configuration::HubConfig>

include/config/Config.h:28:8: warning: [modernize-use-trailing-return-type]

   28 |   bool SaveFromFlatBuffer(const Serialization::Configuration::HubConfig* config);
      |   ~~~~ ^                                                                        
      |   auto                                                                           -> bool

include/config/Config.h:31:8: warning: [modernize-use-trailing-return-type]

   31 |   bool GetRaw(TinyVec<uint8_t>& buffer);
      |   ~~~~ ^                               
      |   auto                                  -> bool

include/config/Config.h:32:8: warning: [modernize-use-trailing-return-type]

   32 |   bool SetRaw(const uint8_t* buffer, std::size_t size);
      |   ~~~~ ^                                              
      |   auto                                                 -> bool

include/config/Config.h:41:8: warning: [modernize-use-trailing-return-type]

   41 |   bool GetRFConfig(RFConfig& out);
      |   ~~~~ ^                         
      |   auto                            -> bool

include/config/Config.h:42:8: warning: [modernize-use-trailing-return-type]

   42 |   bool GetWiFiConfig(WiFiConfig& out);
      |   ~~~~ ^                             
      |   auto                                -> bool

include/config/Config.h:43:8: warning: [modernize-use-trailing-return-type]

   43 |   bool GetCaptivePortalConfig(CaptivePortalConfig& out);
      |   ~~~~ ^                                               
      |   auto                                                  -> bool

include/config/Config.h:44:8: warning: [modernize-use-trailing-return-type]

   44 |   bool GetBackendConfig(BackendConfig& out);
      |   ~~~~ ^                                   
      |   auto                                      -> bool

include/config/Config.h:45:8: warning: [modernize-use-trailing-return-type]

   45 |   bool GetSerialInputConfig(SerialInputConfig& out);
      |   ~~~~ ^                                           
      |   auto                                              -> bool

include/config/Config.h:46:8: warning: [modernize-use-trailing-return-type]

   46 |   bool GetOtaUpdateConfig(OtaUpdateConfig& out);
      |   ~~~~ ^                                       
      |   auto                                          -> bool

include/config/Config.h:47:8: warning: [modernize-use-trailing-return-type]

   47 |   bool GetEStop(EStopConfig& out);
      |   ~~~~ ^                         
      |   auto                            -> bool

include/config/Config.h:49:8: warning: [modernize-use-trailing-return-type]

   49 |   bool SetRFConfig(const RFConfig& config);
      |   ~~~~ ^                                  
      |   auto                                     -> bool

include/config/Config.h:50:8: warning: [modernize-use-trailing-return-type]

   50 |   bool SetWiFiConfig(const WiFiConfig& config);
      |   ~~~~ ^                                      
      |   auto                                         -> bool

include/config/Config.h:51:8: warning: [modernize-use-trailing-return-type]

   51 |   bool SetCaptivePortalConfig(const CaptivePortalConfig& config);
      |   ~~~~ ^                                                        
      |   auto                                                           -> bool

include/config/Config.h:52:8: warning: [modernize-use-trailing-return-type]

   52 |   bool SetBackendConfig(const BackendConfig& config);
      |   ~~~~ ^                                            
      |   auto                                               -> bool

include/config/Config.h:53:8: warning: [modernize-use-trailing-return-type]

   53 |   bool SetSerialInputConfig(const SerialInputConfig& config);
      |   ~~~~ ^                                                    
      |   auto                                                       -> bool

include/config/Config.h:54:8: warning: [modernize-use-trailing-return-type]

   54 |   bool SetOtaUpdateConfig(const OtaUpdateConfig& config);
      |   ~~~~ ^                                                
      |   auto                                                   -> bool

include/config/Config.h:55:8: warning: [modernize-use-trailing-return-type]

   55 |   bool SetEStop(const EStopConfig& config);
      |   ~~~~ ^                                  
      |   auto                                     -> bool

include/config/Config.h:57:8: warning: [bugprone-dynamic-static-initializers]

static variable 'GetWiFiCredentials' may be dynamically initialized in this header file
```
   57 |   bool GetWiFiCredentials(std::vector<WiFiCredentials>& out);
      |        ^
```
include/config/Config.h:57:8: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'GetWiFiCredentials' is non-const and globally accessible, consider making it const

include/config/Config.h:58:8: warning: [modernize-use-trailing-return-type]

   58 |   bool GetWiFiCredentials(cJSON* array, bool withSensitiveData);
      |   ~~~~ ^                                                       
      |   auto                                                          -> bool

include/config/Config.h:59:8: warning: [modernize-use-trailing-return-type]

   59 |   bool SetWiFiCredentials(const std::vector<WiFiCredentials>& credentials);
      |   ~~~~ ^                                                                  
      |   auto                                                                     -> bool

include/config/Config.h:61:8: warning: [modernize-use-trailing-return-type]

   61 |   bool GetRFConfigTxPin(gpio_num_t& out);
      |   ~~~~ ^                                
      |   auto                                   -> bool

include/config/Config.h:62:8: warning: [modernize-use-trailing-return-type]

   62 |   bool SetRFConfigTxPin(gpio_num_t txPin);
      |   ~~~~ ^                                 
      |   auto                                    -> bool

include/config/Config.h:63:8: warning: [modernize-use-trailing-return-type]

   63 |   bool GetRFConfigKeepAliveEnabled(bool& out);
      |   ~~~~ ^                                     
      |   auto                                        -> bool

include/config/Config.h:64:8: warning: [modernize-use-trailing-return-type]

   64 |   bool SetRFConfigKeepAliveEnabled(bool enabled);
      |   ~~~~ ^                                        
      |   auto                                           -> bool

include/config/Config.h:66:8: warning: [modernize-use-trailing-return-type]

   66 |   bool AnyWiFiCredentials();
      |   ~~~~ ^                   
      |   auto                      -> bool

include/config/Config.h:67:8: warning: [bugprone-dynamic-static-initializers]

static variable 'AnyWiFiCredentials' may be dynamically initialized in this header file
```
   67 |   bool AnyWiFiCredentials(std::function<bool(const Config::WiFiCredentials&)> predicate);
      |        ^
```
include/config/Config.h:67:8: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'AnyWiFiCredentials' is non-const and globally accessible, consider making it const

include/config/Config.h:68:11: warning: [modernize-use-trailing-return-type]

   68 |   uint8_t AddWiFiCredentials(std::string_view ssid, std::string_view password, wifi_auth_mode_t authMode = WIFI_AUTH_MAX);
      |           ^

include/config/Config.h:69:8: warning: [modernize-use-trailing-return-type]

   69 |   bool TryGetWiFiCredentialsByID(uint8_t id, WiFiCredentials& out);
      |   ~~~~ ^                                                          
      |   auto                                                             -> bool

include/config/Config.h:69:42: warning: [readability-identifier-length]

   69 |   bool TryGetWiFiCredentialsByID(uint8_t id, WiFiCredentials& out);
      |                                          ^

include/config/Config.h:70:8: warning: [modernize-use-trailing-return-type]

   70 |   bool TryGetWiFiCredentialsBySSID(const char* ssid, WiFiCredentials& out);
      |   ~~~~ ^                                                                  
      |   auto                                                                     -> bool

include/config/Config.h:71:11: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
   71 |   uint8_t GetWiFiCredentialsIDbySSID(const char* ssid);
      |           ^
```

include/config/Config.h:72:8: warning: [modernize-use-trailing-return-type]

   72 |   bool PinWiFiCredentialsBSSID(uint8_t id, const uint8_t (&bssid)[6]);
      |   ~~~~ ^                                                             
      |   auto                                                                -> bool

include/config/Config.h:72:40: warning: [readability-identifier-length]

   72 |   bool PinWiFiCredentialsBSSID(uint8_t id, const uint8_t (&bssid)[6]);
      |                                        ^

include/config/Config.h:72:66: warning: [cppcoreguidelines-avoid-c-arrays]

   72 |   bool PinWiFiCredentialsBSSID(uint8_t id, const uint8_t (&bssid)[6]);
      |                                                                  ^

include/config/Config.h:72:67: warning: [cppcoreguidelines-avoid-magic-numbers]

   72 |   bool PinWiFiCredentialsBSSID(uint8_t id, const uint8_t (&bssid)[6]);
      |                                                                   ^

include/config/Config.h:73:8: warning: [modernize-use-trailing-return-type]

   73 |   bool RemoveWiFiCredentials(uint8_t id);
      |   ~~~~ ^                                
      |   auto                                   -> bool

include/config/Config.h:73:38: warning: [readability-identifier-length]

parameter name 'id' is too short, expected at least 3 characters
```
   73 |   bool RemoveWiFiCredentials(uint8_t id);
      |                                      ^
```

include/config/Config.h:74:8: warning: [modernize-use-trailing-return-type]

   74 |   bool ClearWiFiCredentials();
      |   ~~~~ ^                     
      |   auto                        -> bool

include/config/Config.h:75:8: warning: [modernize-use-trailing-return-type]

   75 |   bool GetWiFiHostname(std::string& out);
      |   ~~~~ ^                                
      |   auto                                   -> bool

include/config/Config.h:76:8: warning: [modernize-use-trailing-return-type]

   76 |   bool SetWiFiHostname(std::string hostname);
      |   ~~~~ ^                                    
      |   auto                                       -> bool

include/config/Config.h:78:8: warning: [modernize-use-trailing-return-type]

   78 |   bool GetBackendDomain(std::string& out);
      |   ~~~~ ^                                 
      |   auto                                    -> bool

include/config/Config.h:79:8: warning: [modernize-use-trailing-return-type]

   79 |   bool SetBackendDomain(std::string domain);
      |   ~~~~ ^                                   
      |   auto                                      -> bool

include/config/Config.h:80:8: warning: [modernize-use-trailing-return-type]

   80 |   bool HasBackendAuthToken();
      |   ~~~~ ^                    
      |   auto                       -> bool

include/config/Config.h:81:8: warning: [modernize-use-trailing-return-type]

   81 |   bool GetBackendAuthToken(std::string& out);
      |   ~~~~ ^                                    
      |   auto                                       -> bool

include/config/Config.h:82:8: warning: [modernize-use-trailing-return-type]

   82 |   bool SetBackendAuthToken(std::string token);
      |   ~~~~ ^                                     
      |   auto                                        -> bool

include/config/Config.h:83:8: warning: [modernize-use-trailing-return-type]

   83 |   bool ClearBackendAuthToken();
      |   ~~~~ ^                      
      |   auto                         -> bool

include/config/Config.h:85:8: warning: [modernize-use-trailing-return-type]

   85 |   bool GetSerialInputConfigEchoEnabled(bool& out);
      |   ~~~~ ^                                         
      |   auto                                            -> bool

include/config/Config.h:86:8: warning: [modernize-use-trailing-return-type]

   86 |   bool SetSerialInputConfigEchoEnabled(bool enabled);
      |   ~~~~ ^                                            
      |   auto                                               -> bool

include/config/Config.h:88:8: warning: [modernize-use-trailing-return-type]

   88 |   bool GetOtaUpdateId(int32_t& out);
      |   ~~~~ ^                           
      |   auto                              -> bool

include/config/Config.h:89:8: warning: [modernize-use-trailing-return-type]

   89 |   bool SetOtaUpdateId(int32_t updateId);
      |   ~~~~ ^                               
      |   auto                                  -> bool

include/config/Config.h:90:8: warning: [modernize-use-trailing-return-type]

   90 |   bool GetOtaUpdateStep(OtaUpdateStep& out);
      |   ~~~~ ^                                   
      |   auto                                      -> bool

include/config/Config.h:91:8: warning: [modernize-use-trailing-return-type]

   91 |   bool SetOtaUpdateStep(OtaUpdateStep updateStep);
      |   ~~~~ ^                                         
      |   auto                                            -> bool

include/config/Config.h:93:8: warning: [modernize-use-trailing-return-type]

   93 |   bool GetEStopEnabled(bool& out);
      |   ~~~~ ^                         
      |   auto                            -> bool

include/config/Config.h:94:8: warning: [modernize-use-trailing-return-type]

   94 |   bool SetEStopEnabled(bool enabled);
      |   ~~~~ ^                            
      |   auto                               -> bool

include/config/Config.h:95:8: warning: [modernize-use-trailing-return-type]

   95 |   bool GetEStopGpioPin(gpio_num_t& out);
      |   ~~~~ ^                               
      |   auto                                  -> bool

include/config/Config.h:96:8: warning: [modernize-use-trailing-return-type]

   96 |   bool SetEStopGpioPin(gpio_num_t gpioPin);
      |   ~~~~ ^                                  
      |   auto                                     -> bool

src/config/Config.cpp:22:23: warning: [bugprone-reserved-identifier]

declaration uses identifier '_configFS', which is reserved in the global namespace
```
   22 | static fs::LittleFSFS _configFS;
      |                       ^~~~~~~~~
      |                       configFS
```
src/config/Config.cpp:22:23: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable '_configFS' is non-const and globally accessible, consider making it const
src/config/Config.cpp:23:27: warning: [bugprone-reserved-identifier]

declaration uses identifier '_configData', which is reserved in the global namespace
```
   23 | static Config::RootConfig _configData;
      |                           ^~~~~~~~~~~
      |                           configData
```
src/config/Config.cpp:23:27: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable '_configData' is non-const and globally accessible, consider making it const
src/config/Config.cpp:24:23: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable '_configMutex' is non-const and globally accessible, consider making it const
```
   24 | static ReadWriteMutex _configMutex;
      |                       ^
```
src/config/Config.cpp:26:9: warning: [cppcoreguidelines-macro-usage]

function-like macro 'CONFIG_LOCK_READ_ACTION' used; consider a 'constexpr' template function
```
   26 | #define CONFIG_LOCK_READ_ACTION(retval, action)  \
      |         ^
```
src/config/Config.cpp:34:9: warning: [cppcoreguidelines-macro-usage]

function-like macro 'CONFIG_LOCK_WRITE_ACTION' used; consider a 'constexpr' template function
```
   34 | #define CONFIG_LOCK_WRITE_ACTION(retval, action)  \
      |         ^
```
src/config/Config.cpp:42:9: warning: [cppcoreguidelines-macro-usage]

function-like macro 'CONFIG_LOCK_READ' used; consider a 'constexpr' template function
```
   42 | #define CONFIG_LOCK_READ(retval)  CONFIG_LOCK_READ_ACTION(retval, {})
      |         ^
```
src/config/Config.cpp:43:9: warning: [cppcoreguidelines-macro-usage]

function-like macro 'CONFIG_LOCK_WRITE' used; consider a 'constexpr' template function
```
   43 | #define CONFIG_LOCK_WRITE(retval) CONFIG_LOCK_WRITE_ACTION(retval, {})
      |         ^
```

src/config/Config.cpp:45:13: warning: [modernize-use-trailing-return-type]

   45 | static bool tryDeserializeConfig(const uint8_t* buffer, std::size_t bufferLen, OpenShock::Config::RootConfig& config)
      |        ~~~~ ^                                                                                                        
      |        auto                                                                                                           -> bool

src/config/Config.cpp:54:17: warning: [cppcoreguidelines-avoid-magic-numbers]

4096 is a magic number; consider replacing it with a named constant
```
   54 |     .max_size = 4096,  // Should be enough
      |                 ^
```

src/config/Config.cpp:73:13: warning: [modernize-use-trailing-return-type]

   73 | static bool tryLoadConfig(TinyVec<uint8_t>& buffer)
      |        ~~~~ ^                                      
      |        auto                                         -> bool

src/config/Config.cpp:97:13: warning: [modernize-use-trailing-return-type]

   97 | static bool tryLoadConfig()
      |        ~~~~ ^              
      |        auto                 -> bool

src/config/Config.cpp:106:13: warning: [modernize-use-trailing-return-type]

  106 | static bool trySaveConfig(const uint8_t* data, std::size_t dataLen)
      |        ~~~~ ^                                                      
      |        auto                                                         -> bool

src/config/Config.cpp:124:13: warning: [modernize-use-trailing-return-type]

  124 | static bool trySaveConfig()
      |        ~~~~ ^              
      |        auto                 -> bool

src/config/Config.cpp:156:15: warning: [modernize-use-trailing-return-type]

  156 | static cJSON* getAsCJSON(bool withSensitiveData)
      |        ~~~~~~ ^                                 
      |        auto                                      -> cJSON*

src/config/Config.cpp:163:21: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
  163 | std::string Config::GetAsJSON(bool withSensitiveData)
      |                     ^
```

src/config/Config.cpp:181:14: warning: [modernize-use-trailing-return-type]

  181 | bool Config::SaveFromJSON(std::string_view json)
      | ~~~~         ^                                  
      | auto                                             -> bool

src/config/Config.cpp:203:70: warning: [modernize-use-trailing-return-type]

  203 | flatbuffers::Offset<Serialization::Configuration::HubConfig> Config::GetAsFlatBuffer(flatbuffers::FlatBufferBuilder& builder, bool withSensitiveData)
      | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~         ^                                                                               
      | auto                                                                                                                                                  -> flatbuffers::Offset<Serialization::Configuration::HubConfig>

src/config/Config.cpp:210:14: warning: [modernize-use-trailing-return-type]

  210 | bool Config::SaveFromFlatBuffer(const Serialization::Configuration::HubConfig* config)
      | ~~~~         ^                                                                        
      | auto                                                                                   -> bool

src/config/Config.cpp:222:14: warning: [modernize-use-trailing-return-type]

  222 | bool Config::GetRaw(TinyVec<uint8_t>& buffer)
      | ~~~~         ^                               
      | auto                                          -> bool

src/config/Config.cpp:229:14: warning: [modernize-use-trailing-return-type]

  229 | bool Config::SetRaw(const uint8_t* buffer, std::size_t size)
      | ~~~~         ^                                              
      | auto                                                         -> bool

src/config/Config.cpp:259:14: warning: [modernize-use-trailing-return-type]

  259 | bool Config::GetRFConfig(Config::RFConfig& out)
      | ~~~~         ^                                 
      | auto                                            -> bool

src/config/Config.cpp:268:14: warning: [modernize-use-trailing-return-type]

  268 | bool Config::GetWiFiConfig(Config::WiFiConfig& out)
      | ~~~~         ^                                     
      | auto                                                -> bool

src/config/Config.cpp:277:14: warning: [modernize-use-trailing-return-type]

  277 | bool Config::GetCaptivePortalConfig(Config::CaptivePortalConfig& out)
      | ~~~~         ^                                                       
      | auto                                                                  -> bool

src/config/Config.cpp:286:14: warning: [modernize-use-trailing-return-type]

  286 | bool Config::GetBackendConfig(Config::BackendConfig& out)
      | ~~~~         ^                                           
      | auto                                                      -> bool

src/config/Config.cpp:295:14: warning: [modernize-use-trailing-return-type]

  295 | bool Config::GetSerialInputConfig(Config::SerialInputConfig& out)
      | ~~~~         ^                                                   
      | auto                                                              -> bool

src/config/Config.cpp:304:14: warning: [modernize-use-trailing-return-type]

  304 | bool Config::GetOtaUpdateConfig(Config::OtaUpdateConfig& out)
      | ~~~~         ^                                               
      | auto                                                          -> bool

src/config/Config.cpp:313:14: warning: [modernize-use-trailing-return-type]

  313 | bool Config::GetEStop(Config::EStopConfig& out)
      | ~~~~         ^                                 
      | auto                                            -> bool

src/config/Config.cpp:322:14: warning: [modernize-use-trailing-return-type]

  322 | bool Config::SetRFConfig(const Config::RFConfig& config)
      | ~~~~         ^                                          
      | auto                                                     -> bool

src/config/Config.cpp:330:14: warning: [modernize-use-trailing-return-type]

  330 | bool Config::SetWiFiConfig(const Config::WiFiConfig& config)
      | ~~~~         ^                                              
      | auto                                                         -> bool

src/config/Config.cpp:338:14: warning: [modernize-use-trailing-return-type]

  338 | bool Config::SetCaptivePortalConfig(const Config::CaptivePortalConfig& config)
      | ~~~~         ^                                                                
      | auto                                                                           -> bool

src/config/Config.cpp:346:14: warning: [modernize-use-trailing-return-type]

  346 | bool Config::SetBackendConfig(const Config::BackendConfig& config)
      | ~~~~         ^                                                    
      | auto                                                               -> bool

src/config/Config.cpp:354:14: warning: [modernize-use-trailing-return-type]

  354 | bool Config::SetSerialInputConfig(const Config::SerialInputConfig& config)
      | ~~~~         ^                                                            
      | auto                                                                       -> bool

src/config/Config.cpp:362:14: warning: [modernize-use-trailing-return-type]

  362 | bool Config::SetOtaUpdateConfig(const Config::OtaUpdateConfig& config)
      | ~~~~         ^                                                        
      | auto                                                                   -> bool

src/config/Config.cpp:370:14: warning: [modernize-use-trailing-return-type]

  370 | bool Config::SetEStop(const Config::EStopConfig& config)
      | ~~~~         ^                                          
      | auto                                                     -> bool

src/config/Config.cpp:378:14: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'GetWiFiCredentials' is non-const and globally accessible, consider making it const
```
  378 | bool Config::GetWiFiCredentials(std::vector<Config::WiFiCredentials>& out)
      |              ^
```

src/config/Config.cpp:387:14: warning: [modernize-use-trailing-return-type]

  387 | bool Config::GetWiFiCredentials(cJSON* array, bool withSensitiveData)
      | ~~~~         ^                                                       
      | auto                                                                  -> bool

src/config/Config.cpp:400:14: warning: [modernize-use-trailing-return-type]

  400 | bool Config::SetWiFiCredentials(const std::vector<Config::WiFiCredentials>& credentials)
      | ~~~~         ^                                                                          
      | auto                                                                                     -> bool

src/config/Config.cpp:402:8: warning: [cppcoreguidelines-init-variables]

  402 |   bool foundZeroId = std::any_of(credentials.begin(), credentials.end(), [](const Config::WiFiCredentials& creds) { return creds.id == 0; });
      |        ^                                            
      |                                                      = false

src/config/Config.cpp:414:14: warning: [modernize-use-trailing-return-type]

  414 | bool Config::GetRFConfigTxPin(gpio_num_t& out)
      | ~~~~         ^                                
      | auto                                           -> bool

src/config/Config.cpp:423:14: warning: [modernize-use-trailing-return-type]

  423 | bool Config::SetRFConfigTxPin(gpio_num_t txPin)
      | ~~~~         ^                                 
      | auto                                            -> bool

src/config/Config.cpp:431:14: warning: [modernize-use-trailing-return-type]

  431 | bool Config::GetRFConfigKeepAliveEnabled(bool& out)
      | ~~~~         ^                                     
      | auto                                                -> bool

src/config/Config.cpp:440:14: warning: [modernize-use-trailing-return-type]

  440 | bool Config::SetRFConfigKeepAliveEnabled(bool enabled)
      | ~~~~         ^                                        
      | auto                                                   -> bool

src/config/Config.cpp:448:14: warning: [modernize-use-trailing-return-type]

  448 | bool Config::AnyWiFiCredentials()
      | ~~~~         ^                   
      | auto                              -> bool

src/config/Config.cpp:455:14: warning: [cppcoreguidelines-avoid-non-const-global-variables]

variable 'AnyWiFiCredentials' is non-const and globally accessible, consider making it const
```
  455 | bool Config::AnyWiFiCredentials(std::function<bool(const Config::WiFiCredentials&)> predicate)
      |              ^
```

src/config/Config.cpp:464:17: warning: [modernize-use-trailing-return-type]

  464 | uint8_t Config::AddWiFiCredentials(std::string_view ssid, std::string_view password, wifi_auth_mode_t authMode)
      |                 ^

src/config/Config.cpp:464:36: warning: [bugprone-easily-swappable-parameters]

  464 | uint8_t Config::AddWiFiCredentials(std::string_view ssid, std::string_view password, wifi_auth_mode_t authMode)
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/config/Config.cpp:464:53: note: the first parameter in the range is 'ssid'
  464 | uint8_t Config::AddWiFiCredentials(std::string_view ssid, std::string_view password, wifi_auth_mode_t authMode)
      |                                                     ^~~~
src/config/Config.cpp:464:76: note: the last parameter in the range is 'password'
  464 | uint8_t Config::AddWiFiCredentials(std::string_view ssid, std::string_view password, wifi_auth_mode_t authMode)
      |                                                                            ^~~~~~~~

src/config/Config.cpp:468:11: warning: [readability-identifier-length]

variable name 'id' is too short, expected at least 3 characters
```
  468 |   uint8_t id = 0;
      |           ^
```

src/config/Config.cpp:517:14: warning: [modernize-use-trailing-return-type]

  517 | bool Config::TryGetWiFiCredentialsByID(uint8_t id, Config::WiFiCredentials& credentials)
      | ~~~~         ^                                                                          
      | auto                                                                                     -> bool

src/config/Config.cpp:517:48: warning: [readability-identifier-length]

  517 | bool Config::TryGetWiFiCredentialsByID(uint8_t id, Config::WiFiCredentials& credentials)
      |                                                ^

src/config/Config.cpp:531:14: warning: [modernize-use-trailing-return-type]

  531 | bool Config::TryGetWiFiCredentialsBySSID(const char* ssid, Config::WiFiCredentials& credentials)
      | ~~~~         ^                                                                                  
      | auto                                                                                             -> bool

src/config/Config.cpp:545:17: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
  545 | uint8_t Config::GetWiFiCredentialsIDbySSID(const char* ssid)
      |                 ^
```

src/config/Config.cpp:558:14: warning: [modernize-use-trailing-return-type]

  558 | bool Config::PinWiFiCredentialsBSSID(uint8_t id, const uint8_t (&bssid)[6])
      | ~~~~         ^                                                             
      | auto                                                                        -> bool

src/config/Config.cpp:558:46: warning: [readability-identifier-length]

  558 | bool Config::PinWiFiCredentialsBSSID(uint8_t id, const uint8_t (&bssid)[6])
      |                                              ^

src/config/Config.cpp:558:72: warning: [cppcoreguidelines-avoid-c-arrays]

  558 | bool Config::PinWiFiCredentialsBSSID(uint8_t id, const uint8_t (&bssid)[6])
      |                                                                        ^

src/config/Config.cpp:558:73: warning: [cppcoreguidelines-avoid-magic-numbers]

  558 | bool Config::PinWiFiCredentialsBSSID(uint8_t id, const uint8_t (&bssid)[6])
      |                                                                         ^

src/config/Config.cpp:572:14: warning: [modernize-use-trailing-return-type]

  572 | bool Config::RemoveWiFiCredentials(uint8_t id)
      | ~~~~         ^                                
      | auto                                           -> bool

src/config/Config.cpp:572:44: warning: [readability-identifier-length]

parameter name 'id' is too short, expected at least 3 characters
```
  572 | bool Config::RemoveWiFiCredentials(uint8_t id)
      |                                            ^
```

src/config/Config.cpp:587:14: warning: [modernize-use-trailing-return-type]

  587 | bool Config::ClearWiFiCredentials()
      | ~~~~         ^                     
      | auto                                -> bool

src/config/Config.cpp:596:14: warning: [modernize-use-trailing-return-type]

  596 | bool Config::GetWiFiHostname(std::string& out)
      | ~~~~         ^                                
      | auto                                           -> bool

src/config/Config.cpp:605:14: warning: [modernize-use-trailing-return-type]

  605 | bool Config::SetWiFiHostname(std::string hostname)
      | ~~~~         ^                                    
      | auto                                               -> bool

src/config/Config.cpp:614:14: warning: [modernize-use-trailing-return-type]

  614 | bool Config::GetBackendDomain(std::string& out)
      | ~~~~         ^                                 
      | auto                                            -> bool

src/config/Config.cpp:623:14: warning: [modernize-use-trailing-return-type]

  623 | bool Config::SetBackendDomain(std::string domain)
      | ~~~~         ^                                   
      | auto                                              -> bool

src/config/Config.cpp:631:14: warning: [modernize-use-trailing-return-type]

  631 | bool Config::HasBackendAuthToken()
      | ~~~~         ^                    
      | auto                               -> bool

src/config/Config.cpp:638:14: warning: [modernize-use-trailing-return-type]

  638 | bool Config::GetBackendAuthToken(std::string& out)
      | ~~~~         ^                                    
      | auto                                               -> bool

src/config/Config.cpp:647:14: warning: [modernize-use-trailing-return-type]

  647 | bool Config::SetBackendAuthToken(std::string token)
      | ~~~~         ^                                     
      | auto                                                -> bool

src/config/Config.cpp:655:14: warning: [modernize-use-trailing-return-type]

  655 | bool Config::ClearBackendAuthToken()
      | ~~~~         ^                      
      | auto                                 -> bool

src/config/Config.cpp:663:14: warning: [modernize-use-trailing-return-type]

  663 | bool Config::GetSerialInputConfigEchoEnabled(bool& out)
      | ~~~~         ^                                         
      | auto                                                    -> bool

src/config/Config.cpp:671:14: warning: [modernize-use-trailing-return-type]

  671 | bool Config::SetSerialInputConfigEchoEnabled(bool enabled)
      | ~~~~         ^                                            
      | auto                                                       -> bool

src/config/Config.cpp:679:14: warning: [modernize-use-trailing-return-type]

  679 | bool Config::GetOtaUpdateId(int32_t& out)
      | ~~~~         ^                           
      | auto                                      -> bool

src/config/Config.cpp:688:14: warning: [modernize-use-trailing-return-type]

  688 | bool Config::SetOtaUpdateId(int32_t updateId)
      | ~~~~         ^                               
      | auto                                          -> bool

src/config/Config.cpp:700:14: warning: [modernize-use-trailing-return-type]

  700 | bool Config::GetOtaUpdateStep(OtaUpdateStep& out)
      | ~~~~         ^                                   
      | auto                                              -> bool

src/config/Config.cpp:709:14: warning: [modernize-use-trailing-return-type]

  709 | bool Config::SetOtaUpdateStep(OtaUpdateStep updateStep)
      | ~~~~         ^                                         
      | auto                                                    -> bool

src/config/Config.cpp:721:14: warning: [modernize-use-trailing-return-type]

  721 | bool Config::GetEStopEnabled(bool& out)
      | ~~~~         ^                         
      | auto                                    -> bool

src/config/Config.cpp:730:14: warning: [modernize-use-trailing-return-type]

  730 | bool Config::SetEStopEnabled(bool enabled)
      | ~~~~         ^                            
      | auto                                       -> bool

src/config/Config.cpp:738:14: warning: [modernize-use-trailing-return-type]

  738 | bool Config::GetEStopGpioPin(gpio_num_t& out)
      | ~~~~         ^                               
      | auto                                          -> bool

src/config/Config.cpp:747:14: warning: [modernize-use-trailing-return-type]

  747 | bool Config::SetEStopGpioPin(gpio_num_t gpioPin)
      | ~~~~         ^                                  
      | auto                                             -> bool

src/main.cpp:25:6: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function
```
   25 | bool trySetup()
      | ~~~~ ^         
      | auto            -> bool
```
src/main.cpp:28:14: warning: [cppcoreguidelines-avoid-c-arrays]

do not declare C-style arrays, use 'std::array' instead
```
   28 |   uint8_t mac[8];
      |              ^
```
src/main.cpp:28:15: warning: [cppcoreguidelines-avoid-magic-numbers]

8 is a magic number; consider replacing it with a named constant
```
   28 |   uint8_t mac[8];
      |               ^
```
src/main.cpp:107:19: warning: [cppcoreguidelines-avoid-magic-numbers]

115'200 is a magic number; consider replacing it with a named constant
```
  107 |   OS_SERIAL.begin(115'200);
      |                   ^
```
src/main.cpp:110:23: warning: [cppcoreguidelines-avoid-magic-numbers]

115'200 is a magic number; consider replacing it with a named constant
```
  110 |   OS_SERIAL_USB.begin(115'200);
      |                       ^
```
src/main.cpp:135:16: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
  135 |     vTaskDelay(5);  // 5 ticks update interval
      |                ^
```

src/main.cpp:142:71: warning: [cppcoreguidelines-avoid-magic-numbers]

  142 |   if (OpenShock::TaskUtils::TaskCreateExpensive(main_app, "main_app", 8192, nullptr, 1, nullptr) != pdPASS) {  // PROFILED: 6KB stack usage
      |                                                                       ^

Have any feedback or feature suggestions? Share it here.

stage-review · 2026-06-29T10:23:57Z

Ready to review this PR? Stage has broken it down into 3 individual chapters for you:

	Title
1	Add WiFi credential existence check to Config
2	Initialize ESP native TCP/IP stack in main
3	Implement native ESP WiFi Manager

_{Chapters generated by Stage for commit eb72546 on Jun 29, 2026 10:23am UTC.}

hhvrc added 5 commits November 11, 2024 17:36

Start working on native wifi manager

b198c25

More scanning logic

2b67c80

More progress i guess

c2ce261

Merge branch 'develop' into refactor/wifi-manager

3a634d3

Seperate ScanManager from WifiManager

439023f

hhvrc self-assigned this Nov 12, 2024

More fixes

6ad45af

hhvrc added this to the ESP-IDF milestone Jul 31, 2025

Merge branch 'develop' into refactor/wifi-manager

b2ba84d

hhvrc changed the title ~~Remove Arduino's WiFi manager~~ feat: Replace Arduino WiFi Manager with esp native Dec 9, 2025

hhvrc changed the title ~~feat: Replace Arduino WiFi Manager with esp native~~ refactor: Replace Arduino WiFi Manager with esp native Dec 9, 2025

hhvrc and others added 3 commits March 27, 2026 00:50

Merge branch 'develop' into refactor/wifi-manager

9ea8372

chore: revert schemas submodule to match develop

fc9e41a

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Merge remote-tracking branch 'origin/develop' into refactor/wifi-manager

eb72546

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: Replace Arduino WiFi Manager with esp native#314

refactor: Replace Arduino WiFi Manager with esp native#314
hhvrc wants to merge 11 commits into
developfrom
refactor/wifi-manager

hhvrc commented Nov 12, 2024

Uh oh!

changeset-bot Bot commented Sep 20, 2025

Uh oh!

github-actions Bot commented Mar 26, 2026 •

edited

Loading

Uh oh!

stage-review Bot commented Jun 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

hhvrc commented Nov 12, 2024

Uh oh!

changeset-bot Bot commented Sep 20, 2025

⚠️ No Changeset found

Uh oh!

github-actions Bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Cpp-Linter Report ⚠️

Uh oh!

stage-review Bot commented Jun 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Mar 26, 2026 •

edited

Loading