Skip to content

Add optional ships_to_display field for vendors #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NanashiTheNameless wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add optional ships_to_display field for vendors #155

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c31b15f
Add optional ships_to_display field for vendors
NanashiTheNameless Jun 8, 2026
31bc93f
improve logic for ships_to_display in vendor table
NanashiTheNameless Jun 8, 2026
c07aef6
Merge branch 'OpenShock:master' into master
NanashiTheNameless Jun 17, 2026
8ec8f55
Merge branch 'OpenShock:master' into master
NanashiTheNameless Jun 18, 2026
c042334
Merge branch 'OpenShock:master' into master
NanashiTheNameless Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/vendor-picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ interface Vendor {
link: string;
from: string;
ships_to: string[];
ships_to_display?: string;
Comment thread
NanashiTheNameless marked this conversation as resolved.
hubs: boolean;
shockers: boolean;
prints3d: boolean;
Expand Down Expand Up @@ -100,6 +101,7 @@ const vendors: Vendor[] = [
link: "./hardware/namelessnanashi",
from: "\ud83c\uddfa\ud83c\uddf8 USA",
ships_to: ["NA"],
ships_to_display: "\ud83c\uddfa\ud83c\uddf8 USA",
hubs: true,
shockers: false,
prints3d: true,
Expand Down Expand Up @@ -201,7 +203,7 @@ function VendorTable({ vendors, region }: { vendors: Vendor[]; region: string })
<Link href={v.link}>{v.name}</Link>
</td>
<td>{v.from}</td>
<td>{v.ships_to.map((r) => regionNames[r]).join(", ")}</td>
<td>{v.ships_to_display ?? v.ships_to.map((r) => regionNames[r]).join(", ")}</td>
Comment thread
NanashiTheNameless marked this conversation as resolved.
Outdated
<td>{checkX(v.hubs)}</td>
<td>{checkX(v.shockers)}</td>
<td>{checkX(v.prints3d)}</td>
Expand Down