Persistent Executions Data: Initial Commit#746
Conversation
…ctions that depend on it instead of refetching it
…ted instance instead of only the id
… it instead of refetching it
…tance server actions file
…t-deployment-data-2
This comment has been minimized.
This comment has been minimized.
|
|
||
| const data = DeploymentInputSchema.parse(input); | ||
|
|
||
| const result = await db.processDeployment.createMany({ |
There was a problem hiding this comment.
Does createMany return the created records here? I mean if caller code expects the actual deployment records (instead of just a count), it might be a problem then. So may be we should use createManyAndReturn or multiple create calls wrapped in a transaction.
There was a problem hiding this comment.
The return value "result" is not used by the calling function "deployProcess" so I removed it.
| if (!skipAbilityCheck) { | ||
| const { ability } = await getCurrentEnvironment(spaceId); | ||
|
|
||
| if (!ability.can('create', 'Execution')) |
There was a problem hiding this comment.
I think we also have update ability. If I am not wrong then may be here; for an update operation, 'update' permission should be checked
There was a problem hiding this comment.
Absolutely correct. I changed the permission check to 'udpate'.
This comment has been minimized.
This comment has been minimized.
|
✅ Successfully created Preview Deployment. |
2 participants
Summary
First parts of our persistent execution data implementation. Added db tables to store information about process deployments and instances and update the data on user input.
Details
Engine
Management System